Fix/audit fixes round 8 (#37)

* fix: unecessary additonal assignment in compound interest calculation return * fix: L-9. recallWindow > 0 isn’t enforced * fix: reuse error messages * fix: gas optimizations for assignments
AstariaXYZ · Jan 25, 2024 · 5703cd2 · 5703cd2
1 parent d760601
commit 5703cd2
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 6 deletions.
diff --git a/lib/starport b/lib/starport
diff --git a/src/lib/AstariaV1Lib.sol b/src/lib/AstariaV1Lib.sol
@@ -54,7 +54,7 @@ library AstariaV1Lib {
             int256 exponent = int256((rate * baseAdjustment * delta_t) / 365 days);
             amount *= baseAdjustment;
             uint256 result = amount.mulWad(uint256(exponent.expWad())) - amount;
-            return result /= baseAdjustment;
+            return result / baseAdjustment;
         }
         int256 exponent = int256((rate * delta_t) / 365 days);
         return amount.mulWad(uint256(exponent.expWad())) - amount;

diff --git a/src/settlement/AstariaV1Settlement.sol b/src/settlement/AstariaV1Settlement.sol
@@ -34,7 +34,6 @@ contract AstariaV1Settlement is DutchAuctionSettlement {
 
     error LoanNotRecalled();
     error NoAuction();
-    error AuctionStartBeforeNow();
 
     /*´:°•.°+.*•´.*:˚.°*.˚•´.°:°•.°•.*•´.*:˚.°*.˚•´.°:°•.°+.*•´.*:*/
     /*                        CONSTRUCTOR                         */
@@ -139,14 +138,14 @@ contract AstariaV1Settlement is DutchAuctionSettlement {
             }
 
             if (recaller == loan.issuer) {
-                return (new ReceivedItem[](0), recaller);
+                return (consideration, recaller);
             }
 
             start = _getAuctionStart(loan, recallStart);
         }
 
         if (block.timestamp < start) {
-            revert AuctionStartBeforeNow();
+            revert AuctionNotStarted();
         }
 
         Details memory details = abi.decode(loan.terms.settlementData, (Details));

diff --git a/src/status/AstariaV1Status.sol b/src/status/AstariaV1Status.sol
@@ -63,7 +63,7 @@ contract AstariaV1Status is BaseStatus, BaseRecall, Ownable {
         bool valid = true;
         if (
             details.recallerRewardRatio > 10 ** pDetails.decimals || details.recallMax > 10 * 10 ** pDetails.decimals
-                || !isValidPricing[loan.terms.pricing] || details.recallMax == 0
+                || !isValidPricing[loan.terms.pricing] || details.recallMax == 0 || details.recallWindow == 0
         ) {
             valid = false;
         }
+80 −81		.gas-snapshot
+7 −13		src/BNPLHelper.sol
+6 −5		src/Custodian.sol
+8 −6		src/lib/StarportLib.sol
+10 −18		src/originators/StrategistOriginator.sol
+1 −2		src/pricing/BasePricing.sol
+4 −2		src/settlement/DutchAuctionSettlement.sol
+1 −1		test/StarportTest.sol
+1 −1		test/unit-testing/TestCustodian.sol
+3 −5		test/unit-testing/TestStarport.sol
+0 −7		test/unit-testing/TestStrategistOriginator.sol