Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Egui 0.28 update fixes #145

Merged
merged 5 commits into from
Jul 27, 2024
Merged

Egui 0.28 update fixes #145

merged 5 commits into from
Jul 27, 2024

Conversation

white-axe
Copy link
Collaborator

Connections

Description
This fixes some problems caused by the egui update in #143, namely the preset visuals tab in the preferences causing a panic and the wrap modes of several of the menus being broken.

I also updated the time crate to fix a compilation error when using certain new Rust compiler versions and fixed a problem where blank lines sometimes appear at the bottom of the filesystem debug window, although these problems existed before the egui update.

Testing

  • The preset visuals tab in the preferences shouldn't cause a panic anymore.
  • None of the items in any of the menus, e.g. the menus in the top bar, the database editor dropdown menus and the "Cursor blinking" setting in the terminal settings in the preferences, should have wrapping text anymore.
  • There should be no blank lines at the bottom of the filesystem debug window when opening a project with the standard RTP for RPG Maker XP placed in the RTP subdirectory of the project directory.
  • It should be possible to compile Luminol with nightly Rust versions later than 2024-05-19.

Checklist

  • Run cargo fmt.
  • Run cargo clippy. If applicable, add:
    • --target wasm32-unknown-unknown -Z build-std=std,panic_abort
  • Run cargo build --release
  • If applicable, run trunk build --release

@white-axe white-axe requested a review from a team as a code owner July 27, 2024 22:10
@white-axe white-axe merged commit f67bfdd into Astrabit-ST:dev Jul 27, 2024
4 checks passed
@white-axe white-axe deleted the ui-fixes branch July 27, 2024 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants