Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR] Disable Automatic Folder Discovery #1049

Merged
merged 11 commits into from
Mar 16, 2024

Conversation

the-P1neapple
Copy link
Member

@the-P1neapple the-P1neapple commented Mar 8, 2024

Questions

Describe your pull request

This is a patch based on the Shell Bags Registry which is in charge of custom view properties when loading a folder. Disabling this has potential to speed up indexing on older hard drives by preventing automatic view changes based on the content present in the folder.

@github-actions github-actions bot added the playbook Playbook related issues/PRs label Mar 8, 2024
@Xyueta
Copy link
Member

Xyueta commented Mar 8, 2024

looks good to me

@Xyueta Xyueta requested a review from he3als March 8, 2024 15:58
@he3als
Copy link
Contributor

he3als commented Mar 9, 2024

Automatic folder discovery is useful for selecting certain views in Explorer, such as your 'Pictures' folder being set to thumbnail/icon view by default.

Disabling it by default can annoy some users, including me when I used to use this tweak.

To disable it by default, it would be best to have a good confirmation of how this speeds up Explorer first. Additionally, there should be Optional Tweaks Registry files to toggle the feature.

@Xyueta
Copy link
Member

Xyueta commented Mar 10, 2024

@the-P1neapple
Copy link
Member Author

https://twitter.com/unitycoder_com/status/1764550045070721212

I originally found out about this tweak from Endermanch in his telegram but I didn't realise it was this effective.
@he3als do you want me to still want me to put this in optional tweaks or in the main configuration folder?

@he3als
Copy link
Contributor

he3als commented Mar 10, 2024

In that case, it can be disabled by default then as a performance over QoL tweak

@the-P1neapple the-P1neapple marked this pull request as draft March 10, 2024 23:45
@the-P1neapple the-P1neapple marked this pull request as ready for review March 11, 2024 04:06
@the-P1neapple
Copy link
Member Author

Sorry I thought when you said 'disabled by default' you didn't want the tweak to run by default. This should be good now.

@he3als he3als merged commit 86fd3b9 into Atlas-OS:dev Mar 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
playbook Playbook related issues/PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants