Backport features from k8IVAN #665
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge master
Update master
Also slightly distinguish siren subtypes via different Charisma, just because. And nerf Charisma of Elianise a bit, as she had more Charisma than archangels...
added 5 commits
February 12, 2025 10:30
I seem to have cherry-picked unfinished commits.
|
Yeah #661 was trying to update PCRE to PCRE2. It worked on Linux (I even tested it..?), but I can see macos platform may need to be updated as well. Probably we need to add separate windows and mac configs to the I pushed the minimum needed changes to get actions to check PRs again. |
Thanks, less work for me. :D |
added 9 commits
February 14, 2025 09:58
This save file version check seems to be a vestige of previous version that got left in... Fixes Attnam#669
While this doesn't fix anything, at least this makes sure that the player knows what they are getting into. Crafting can be pretty unstable, so I feel it's reasonable to relegate it to an experimental option.
We have quite a few new options, yet many are disabled by default. A lot of players will never give the Options menu much thought, so they will never discover some nifty quality of life additions that are in the game for many years now. This attempts to set all options that improve QoL but do not alter base IVAN experience as enabled by default. Full screen is on by default now. I have seen many players complain about the small window and I think those who do NOT use fullscreen are in minority. Various extra info and better handling options are enabled. Graphics scaling is NOT enabled by default, because while nice, it radically alters the game's looks, in a way that I feel should not be the default. Old vanilla IVAN graphics still looks the best! StartWithNoPet became StartWithPet. It is a bool option and there is no need to make it negative and thus confusing. Also reorganizes the Options menu to group similar options and to better fit each section on each page.
There is no need to be inconsistent. Offer already uses uppercase in two command sets.
This has bothered me for quite a while. Most commands are same in IVAN and NetHack, but NetHack uses (q)uaff, not drink. And we have lowercase q free, so why not make the scheme consistent with NetHack?
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
added 4 commits
February 17, 2025 09:42
Oops, ectoplasm is gas, not liquid.
added 4 commits
February 21, 2025 11:42
This is already shown in square brackets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.