Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rustfmt #16

Closed
wants to merge 6 commits into from
Closed

Rustfmt #16

wants to merge 6 commits into from

Conversation

tillarnold
Copy link

@tillarnold tillarnold commented Nov 2, 2023

Builds on top of #15. To see what changed since #15 see https://github.com/tillarnold/prusti-dev/compare/till_rebuilt_3..tillarnold:prusti-dev:rustfmt

Run rustfmt on the entire project.

I did this by running cargo fmt in the repo root as well as in prusti-contracts as that appears to be a different workspace. Running ./x.py fmt-all resulted in an error. Old prusti recently merged a PR that changed how the formatting in x.py works viperproject#1456. Maybe that fix could be relevant here too?

@JonasAlaif
Copy link
Collaborator

Let's only run cargo fmt on code that is specifically in this repo (i.e. prust-encoder and the like). If we format everything then it will cause conflicts when we try to merge in work from other branches for the other directories.

@JonasAlaif
Copy link
Collaborator

Also we need to only do this after #11 to avoid conflicts with that

@tillarnold tillarnold mentioned this pull request Nov 7, 2023
2 tasks
@tillarnold tillarnold closed this Nov 10, 2023
@tillarnold tillarnold mentioned this pull request Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants