-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Additional Status and AI Panels #20220
base: master
Are you sure you want to change the base?
Conversation
Discused over discord, did a sweep through to deal with clipping issues |
There is still a ton of places that have overlapping/clipping wall-mountables I see no point in spamming these status panels everywhere. They are huge and just don't look good, and they are not proper 3/4 with all the perspectives. like this just looks really bad with the huge status panels are bigger than the wall itself and always face south |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as above, please fix all the clipping issues
also IMO all these status panels should be only south facing walls to fit the only perspective they have currently
And being just a dev, I have no power to deny this PR, but I do not like it (reasoning above)
Did do another look around but overall seems good. as for sprite issue, I don't know enough about spritework to know how this sprite could be changed to fit 3/4 perspective better while not compromising the content. The goal for the PR is that the status panels are very sparse and oftentimes not in areas people would see. I can see the argument for reducing some but we should have more |
Also they seem fine in other directions clip wise |
They shouldn't look like they clip when looking at them in strongdmm/mapdiffbot, even if they look fine in game. It hurts readability. And I do not see why there should be multiple panels in the same areas, like the OM office or bridge entrance. |
those multiple panels are supply panels, AI panels, status panels, etc etc. They are different Will adjust the clipping ones though |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Title
Adds multiple new Status and AI panels across the vessel, with goal of having status panels at most high-traffic areas