Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Additional Status and AI Panels #20220

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Ben10083
Copy link
Contributor

Title

Adds multiple new Status and AI panels across the vessel, with goal of having status panels at most high-traffic areas

@github-actions github-actions bot added the 🗺️ Mapping - Horizon The PR touches the Horizon map files. label Nov 29, 2024
@hazelrat
Copy link
Contributor

image
Multiple displays in a single room seems excessive to me, especially considering the light fixtures will be awkwardly on top of their screens ingame?

@Ben10083
Copy link
Contributor Author

htTiW950xD-3XDqk4cyx_3OFIToa9Cl_IvHOVqYS-CE) Multiple displays in a single room seems excessive to me, especially considering the light fixtures will be awkwardly on top of their screens ingame?

Discused over discord, did a sweep through to deal with clipping issues

@DreamySkrell
Copy link
Contributor

DreamySkrell commented Dec 4, 2024

image
image
image
image
image
image

There is still a ton of places that have overlapping/clipping wall-mountables

I see no point in spamming these status panels everywhere. They are huge and just don't look good, and they are not proper 3/4 with all the perspectives.

image

like this just looks really bad with the huge status panels are bigger than the wall itself and always face south

Copy link
Contributor

@DreamySkrell DreamySkrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as above, please fix all the clipping issues

also IMO all these status panels should be only south facing walls to fit the only perspective they have currently

And being just a dev, I have no power to deny this PR, but I do not like it (reasoning above)

@Ben10083
Copy link
Contributor Author

Ben10083 commented Dec 4, 2024

There is still a ton of places that have overlapping/clipping wall-mountables

(Ingame)
image
image
image
image
image

Did do another look around but overall seems good.

as for sprite issue, I don't know enough about spritework to know how this sprite could be changed to fit 3/4 perspective better while not compromising the content.

The goal for the PR is that the status panels are very sparse and oftentimes not in areas people would see. I can see the argument for reducing some but we should have more

@Ben10083 Ben10083 requested a review from DreamySkrell December 4, 2024 20:25
@Ben10083
Copy link
Contributor Author

Ben10083 commented Dec 4, 2024

Also they seem fine in other directions clip wise

@DreamySkrell
Copy link
Contributor

DreamySkrell commented Dec 4, 2024

They shouldn't look like they clip when looking at them in strongdmm/mapdiffbot, even if they look fine in game. It hurts readability.

And I do not see why there should be multiple panels in the same areas, like the OM office or bridge entrance.

@Ben10083
Copy link
Contributor Author

Ben10083 commented Dec 5, 2024

They shouldn't look like they clip when looking at them in strongdmm/mapdiffbot, even if they look fine in game. It hurts readability.

And I do not see why there should be multiple panels in the same areas, like the OM office or bridge entrance.

those multiple panels are supply panels, AI panels, status panels, etc etc. They are different

Will adjust the clipping ones though

Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants