add storage to oe template (not working) (DO NOT MERGE) #1720
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @Quazia @ottodevs and @topocount this is my first attempt at adding a default storage app to the OE template. This first commit is just to get the contracts working, and not any of the frontend / parcel stuff yet.
Important files:
changes to
BaseOEApps
changes to
DevTemplate.sol
storage app
package.json
storage app
Storage.sol
The dev template compiles (verified by navigating into the dev template directory and manually running
npm run compile
). But attempting tonpm run start:dev
from the root directory gets a VM revert:Before diving in any further I wanted to ask you a few Q's:
start:dev
with the@aragon/cli
?If the revert is coming from a solidity error that I overlooked, I'm happy to keep poking around (or let me know if you see it!). Would be convenient to not have to separately install.
Thanks for any help!