Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overdue bounties correct status info #1829

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Conversation

rkzel
Copy link
Collaborator

@rkzel rkzel commented Dec 21, 2019

Additionally IssueDetails (Bounty widget) and Issue Card needed to notice bounty's expiration and show appropriate information, as per Figma design. Screens of the Issue Card:

Not completed:

Screenshot from 2019-12-21 12-16-57

Bounty in progress, number information added (1 bounty is the default and only option right now):

Screenshot from 2019-12-21 12-18-30

Bounty completed (reduction in number of items):

Screenshot from 2019-12-21 12-24-28

Bounty widget past due date without submissions:

Screenshot from 2019-12-21 19-26-19

Bounty widget past due date with submissions (panels open in RO mode):

Screenshot from 2019-12-21 19-32-14

BountyContextMenu for expired bounties reverts to 'Fund issue'. It opens "bounty update" form (alternative solution: it could perform removing bounty first, one additional transaction). Currently it's returning "not enough permissions" upon submitting - not sure if it is my setup, or... in any case it needs some further testing.

Additionally IssueDetails (Bounty widget) and Issue Card needed
to notice bounty's expiration and show appropriate information,
as per Figma design and this ticket:

#1797
@rkzel rkzel changed the title fix: bounty status after deadline didn't revert to 'not-funded' Overdue bounties correct status info Dec 21, 2019
@rkzel rkzel marked this pull request as ready for review December 21, 2019 21:24
Copy link
Collaborator

@chadoh chadoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BountyContextMenu for expired bounties reverts to 'Fund issue'. It opens "bounty update" form (alternative solution: it could perform removing bounty first, one additional transaction). Currently it's returning "not enough permissions" upon submitting - not sure if it is my setup, or... in any case it needs some further testing.

I want to get input from @topocount or @Quazia or @ottodevs on this before we merge. Also, what method did you use to test this?

I tested locally and everything seems to work pretty well, other than the above, which I couldn't figure out how to test without waiting 24 hours. I did note some small code cleanup that I'd like to see before we merge, too.

@chadoh chadoh assigned ottodevs, Quazia and topocount and unassigned chadoh Jan 3, 2020
Copy link
Collaborator

@chadoh chadoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me, but please wait for an approving review from @Quazia / @topocount / @ottodevs before merging

@rkzel
Copy link
Collaborator Author

rkzel commented Jan 7, 2020

There is more to this. Namely: what exactly should and can happen after a bounty expires.
What should happen: the bounty can be edited and deadline extended, possibly with changed parameters like funding and exp level. I have spent too much time getting old updateBounty function back into life, but that function does not emit appropriate event (so can't update frontend automatically) and it can only change limited set of details of a bounty, so it is of not much use to us as it is right now. That makes quarter of Funding Panel obsolete by the way - I'm happy to clean up.. The other possibility is to remove that bounty and create new funding. Two transactions, but it looks like a more viable way.

Copy link
Collaborator

@topocount topocount left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs some more rework and testing.

When there are multiple submissions the acceptance only appears on the most recent submission and the previously accepted submission (if not the latest submission) still has buttons for acceptance or rejection:
image

@rkzel rkzel requested a review from a team as a code owner January 10, 2020 22:56
@ghost ghost requested review from topocount and removed request for a team January 10, 2020 22:56
@stellarmagnet stellarmagnet added this to the Offsite Hackathon milestone Jan 28, 2020
@javieralaves javieralaves added app: projects bug Something isn't working labels Jan 28, 2020
@ottodevs ottodevs assigned rkzel and unassigned ottodevs, Quazia and topocount Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app: projects bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants