Scope module assets for calendar #564
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cojennin
force-pushed
the
scope-module-assets-calendar
branch
from
2d0cca7 to
a616c4e
Compare
cojennin
added
[Status] Needs Review
[Status] In-Progress
and removed
[Status] In-Progress
[Status] Needs Review
labels
cojennin
commented
Dec 19, 2019
| @@ -215,15 +215,15 @@ function filter_posts_link( $slug, $post_type = 'post' ) { | |||
| */ | |||
| function enqueue_datepicker_resources() { | |||
|
|
|||
| // Add the first day of the week as an available variable to wp_head | |||
| echo "<script type=\"text/javascript\">var ef_week_first_day=\"" . get_option( 'start_of_week' ) . "\";</script>"; | |||
There was a problem hiding this comment.
This line was making the PHPUnit tests around enqueuing noisy, so moved it to use wp_add_inline_script
cojennin
force-pushed
the
scope-module-assets-calendar
branch
from
1854d73 to
123c1fe
Compare
cojennin
force-pushed
the
scope-module-assets-calendar
branch
from
123c1fe to
65095fa
Compare
|
Let's hold off on this one until we have a good pattern down in #565. Once the first is merged and a good pattern is setup, the rest can follow suit. |
|
Closing this for now, going to rework based on thoughts in #565 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on work from @justnorris in #487.
Instead of trying to tackle scoping assets across all of Edit Flow at once, we'll create a series of PR's to bring different modules into alignment and then introduce stricter guardrails once all the modules are in better shape.