-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Dockerfile #48
base: master
Are you sure you want to change the base?
Add Dockerfile #48
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
I like the idea, but this should be more generic; so not just
git
but alsohg
,bzr
,svn
andgit-svn
. -
Additionally, besides the repo types autorevision also uses the following non builtin commands:
sed
,cut
,grep
,wc
,tail
,basename
,dirname
,tee
,getopts
,tr
andcmp
. -
Also, it should use the installed version of autorevision not the .sh file.
-
I am not familiar enough with docker to know where this would best go, but the man page (and possibly other docs) should be somewhere as well.
On your second point. The container this Dockerfile builds is based on base alpine linux distribution. So it already has all non-built in commands. Look at the test below. You can verify it for yourself, using the docker command from the test. All you need to have installed is just docker.
|
I see your point about the support of multiple revisions. But this makes pretty large container, 115MB with all VCS installed vs 26MB with just git.
Maybe we should have two different images one just for git as it's most common use case these days and another one with everything else included |
fa8b378
to
a3450ac
Compare
a3450ac
to
094d35a
Compare
Now there are two Dockerfiles one with just GIT and another one with the rest of the VCS ( hg, svn, bzr) Also, I am no longer copying the shell script, but doing 'make install' Let me know what you think |
As for the docs, do you it's better to put into man page, or have a separate README just for docker? |
As I have never used docker before (personally I tend to use jails instead), I am not sure what would have the best visibility from inside docker but I definitely think a separate readme is in order to go over how the docker images are meant to be used. |
Ok, I'll write a separate README and put it in the directory with Docker files. |
Ok, readme is there now. Note, I put the references to my personal account in Dockerhub. Might be a good thing if you could create an Autorevision account in dockerhub and hook the this repo, so you'll always have the fresh containers built automatically once changes are checked in into this repository. I can walk you through creating the account. Dockerhub has the same policy to open source as the github. Hosting is always free for the containers that are publicly available. |
I did not see a free tier for orgs; only individuals. |
Actually, they changed their naming scheme. All you need is to create an account named 'Autorevision' and link it to the github repo |
On modern CI server sometimes it’s handy to run such small tools from Docker container instead of making sure it exists on every build host
If you choose to accept this PR, you'll need to create an account on docker hub, and enroll this repository in there. They will auto-build and auto-distribute everything for you.
Preflight Checklist
I have: