Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix those damn placeholder conditions #183

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

NicoNekoDev
Copy link
Contributor

@NicoNekoDev NicoNekoDev commented Feb 7, 2025

Firstly, in the wiki (https://plugins.auxilor.io/effects/all-conditions/placeholder_greater_than) it says "greater than or equal" for placeholder_higher_than condition, which it's not actually the case as the operator is > and not >=.
Secondly, it should be a mathematical evaluation, not a formatted string followed by a conversion to double. Probably this is why in most cases, those 2 conditions don't work accordingly with placeholders, if any space, or character, or whatever is present.
Thirdly, allow placeholders to be evaluated in both placeholder and value arguments.

@NicoNekoDev NicoNekoDev requested a review from WillFP as a code owner February 7, 2025 10:23
@NicoNekoDev
Copy link
Contributor Author

NicoNekoDev commented Feb 7, 2025

Please also consider adding an optional argument or_equals instead of forcing to be equals too (for both conditions).

@NicoNekoDev NicoNekoDev changed the title Fix those damn placeholders Fix those damn placeholder conditions Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant