Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boolean table cell in edit mode #2258

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

FredLL-Avaiga
Copy link
Member

resolves #2257

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Boolean table cell in edit mode

Related Tickets & Documents

How to reproduce the issue

import pandas as pd

import taipy.gui.builder as tgb
from taipy import Gui

data = pd.DataFrame(
    {"Include": [True, False, True], "A": [1, 2, 3], "B": [4, 5, 6], "C": [7, 8, 9]}
)

with tgb.Page() as page:
    tgb.table("{data}", editable__Include=True)

    tgb.table("{data}", editable__Include=True, use_checkbox=True)

Gui(page).run(title="2257 [🐛 BUG] Weird syntax when editing a boolean in Table")

Checklist

  • Does this solution meet the acceptance criteria of the related issue?
  • Is the related issue checklist completed?
  • Does this PR adds unit tests for the developed code? If not, why?
  • End-to-End tests have been added or updated?
  • Was the documentation updated, or a dedicated issue for documentation created? (If applicable)
  • Is the release notes updated? (If applicable)

@FredLL-Avaiga FredLL-Avaiga added 🟥 Priority: Critical Must be addressed as soon as possible 💥Malfunction Addresses an identified problem. 📝Release Notes Impacts the Release Notes or the Documentation in general GUI: Front-End labels Nov 18, 2024
@FredLL-Avaiga FredLL-Avaiga self-assigned this Nov 18, 2024
Copy link
Member

@dinhlongviolin1 dinhlongviolin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 line does make a big difference.

Copy link
Contributor

github-actions bot commented Nov 18, 2024

Coverage report for ./frontend/taipy

Caution

Coverage does not meet threshold
Statements coverage not met for global: expected >=80%, but got 52.07920792079208%

St.
Category Percentage Covered / Total
🔴 Statements 52.08% 263/505
🔴 Branches 21.75% 67/308
🔴 Functions 14.66% 17/116
🔴 Lines 53.42% 242/453

Test suite run success

7 tests passing in 1 suite.

Report generated by 🧪jest coverage report action from db05b9c

Copy link
Contributor

Coverage report for ./frontend/taipy-gui

Caution

Coverage does not meet threshold
Branches coverage not met for global: expected >=80%, but got 69.3969396939694%

St.
Category Percentage Covered / Total
🟢 Statements 87.84% 3403/3874
🟡 Branches
69.4% (+0.08% 🔼)
2313/3333
🟢 Functions 83.64% 629/752
🟢 Lines 88.31% 3149/3566

Test suite run success

690 tests passing in 47 suites.

Report generated by 🧪jest coverage report action from db05b9c

Copy link
Contributor

github-actions bot commented Nov 18, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
19289 16774 87% 0% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: db05b9c by action🐍

Copy link
Member

@FabienLelaquais FabienLelaquais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Funny

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GUI: Front-End 💥Malfunction Addresses an identified problem. 🟥 Priority: Critical Must be addressed as soon as possible 📝Release Notes Impacts the Release Notes or the Documentation in general
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐛 BUG] Weird syntax when editing a boolean in Table
4 participants