use native secp256k1 #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks pretty good. Your secp256k1 library looks good. Maybe I can convince you to help out on my blockchain platform https://sushichain.io :) |
|
replaced all secp256k1 with the native library except for encrypt/decrypt. ref q9f/secp256k1.cr#22 note, that apparently, I used a different signing algorithm. this should not be merged until I figure out how to match your signature scheme. tests pass because it only verifies self-generated signatures. |
|
I'm going to start using this - the signing algorithm is not an issue - I've re-worked a few things so it's compatible. |
|
cool |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #4
just seeing how my library applies in the wild.