Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Update RaiderIO hooks #114

Merged
merged 1 commit into from
Feb 7, 2023
Merged

Conversation

ArthurEnglebert
Copy link
Contributor

RaiderIO addon had different names; one was RaiderIO, the new packaging is "Raiderio", notice the difference in the end.

RaiderIO addon had different names; one was RaiderIO, the new packaging is "Raiderio", notice the difference in the end.
@ArthurEnglebert
Copy link
Contributor Author

ArthurEnglebert commented Feb 7, 2023

RaiderIO/raiderio-addon#196 here is the issue wrongly submitted to RaiderIO devs
https://github.com/RaiderIO/raiderio-addon/blob/develop/core.lua#L6234 here is the actual creation of the problematic frame

This also comes from the fact that addon existence is checked via "strlower" addon name while the frame lookup is case sensitive

function AS:CheckAddOn(addon)
	return AS.AddOns[strlower(addon)] or false
end

I don't know myself a lot of lua, so this fix might look ugly & probably better way to refactor the whole code base, but at least, this pr will shine some light on it

@nihilistzsche nihilistzsche merged commit a7099f0 into Azilroka:main Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants