-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wotlk cooldown additions #12
Open
SaschaJankowiak
wants to merge
7
commits into
AznamirWoW:master
Choose a base branch
from
zidWoW:wotlk-cooldown-additions
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Wotlk cooldown additions #12
SaschaJankowiak
wants to merge
7
commits into
AznamirWoW:master
from
zidWoW:wotlk-cooldown-additions
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added cooldowns.improved stat to tell if the cooldowns are improved e.g. layonhands or divine guardian
…sings, auras and cooldowns properly
SaschaJankowiak
commented
Aug 3, 2022
Blessingsframe looking like this (screenshotted in tbc-client) |
FKinn
approved these changes
Aug 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems legit
EsreverWoW
reviewed
Aug 21, 2022
…d divine guardian aswell
with ptrs being available today (last days i tried they where offline all the time...) I did a lot of testing - current commit seems to work flawlessly for me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Aura Mastery and Divine Guardian/Divine Sacrifice to the Wrath part of the Addon. Also added an alternative icon of LayOnHands if it's improved to reflect if it can count as a real Cooldown or not.
as @EsreverWoW is currently Working on Wrath-Beta-Stuff he should take a look - don't know if GetTalents now works correctly in Beta