Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wotlk cooldown additions #12

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

SaschaJankowiak
Copy link
Contributor

Added Aura Mastery and Divine Guardian/Divine Sacrifice to the Wrath part of the Addon. Also added an alternative icon of LayOnHands if it's improved to reflect if it can count as a real Cooldown or not.

as @EsreverWoW is currently Working on Wrath-Beta-Stuff he should take a look - don't know if GetTalents now works correctly in Beta

added cooldowns.improved stat to tell if the cooldowns are improved e.g. layonhands or divine guardian
PallyPower.lua Outdated Show resolved Hide resolved
@SaschaJankowiak
Copy link
Contributor Author

Blessingsframe looking like this (screenshotted in tbc-client)

Copy link

@FKinn FKinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit

PallyPower.lua Outdated Show resolved Hide resolved
@EsreverWoW
Copy link
Collaborator

I think the XML layout could use a bit of work. This is how it looks for me.
image

Could use some padding for the Free Assignment checkbox and the various buttons at the bottom.

Here's the master branch right now for comparison.
image

@SaschaJankowiak
Copy link
Contributor Author

I think the XML layout could use a bit of work. This is how it looks for me. image

Could use some padding for the Free Assignment checkbox and the various buttons at the bottom.

Here's the master branch right now for comparison. image

the calculated offset inside PallyPower.lua was not properly modified. fixed this all in current version

@SaschaJankowiak
Copy link
Contributor Author

with ptrs being available today (last days i tried they where offline all the time...) I did a lot of testing - current commit seems to work flawlessly for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants