Request: (Draft) Add support for Shaman on vanilla cross faction servers #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added libraries
- Added buttons for shaman in the ui
- There are still some graphical issues with dividers. - Templates are certainly wrong as shamans are taking the spot for pets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Private servers are supporting the use of the 1.14.2 client and a proxy to play on the 1.12.1 servers.
Many private servers have a low population and thus allow for cross faction. This makes buffing Shamans cumbersome as they are not tracked by PallyPower. I would like an option to show Shamans in the buff assignment and the tracker.
I read your license that said that no one but you can distribute this addon, so I am reaching out in the hopes that you would add support for shamans, so that I do not violate your license.
I have tried to make a rough PR to simply test if it works, and so far this works alright.
There are some issue with the graphical part of the buff assignment as seen here:
But tracking the buff on the small sidebar works flawlessly.
I will leave it up to you if you want shamans to always be available, or if there should be a toggle to decide if they should be shown or not.
I hope you will consider this request.
Best regards
DBFBlackbull