-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(avm): range checks in vm2 #11433
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copied this file over but renamed some things and removed the selectors specifying which subtrace a range check originated from
9e6df37
to
834e682
Compare
sel {op1, op2, op3, op4} is sel {op1, op2, op3, op4}; No newline at end of file | ||
sel {op1, op2, op3, op4} is sel {op1, op2, op3, op4}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know what's different about our editors, but this happens all the time
barretenberg/cpp/src/barretenberg/vm2/simulation/range_check.test.cpp
Outdated
Show resolved
Hide resolved
barretenberg/cpp/src/barretenberg/vm2/tracegen/range_check_trace.cpp
Outdated
Show resolved
Hide resolved
barretenberg/cpp/src/barretenberg/vm2/simulation/events/range_check_event.hpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great from a VM2 perspective!
barretenberg/cpp/src/barretenberg/vm2/constraining/relations/alu.test.cpp
Outdated
Show resolved
Hide resolved
barretenberg/cpp/src/barretenberg/vm2/constraining/relations/range_check.test.cpp
Outdated
Show resolved
Hide resolved
barretenberg/cpp/src/barretenberg/vm2/constraining/relations/range_check.test.cpp
Show resolved
Hide resolved
barretenberg/cpp/src/barretenberg/vm2/tracegen/range_check_trace.cpp
Outdated
Show resolved
Hide resolved
barretenberg/cpp/src/barretenberg/vm2/tracegen/lib/lookup_into_rng_chk.hpp
Outdated
Show resolved
Hide resolved
// Range check selector | ||
pol commit sel_rng_chk; | ||
sel_rng_chk * (1 - sel_rng_chk) = 0; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add
// No relations will be checked if this identity is satisfied.
#[skippable_if]
sel = 0;
?
we can discuss skippable in a huddle
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's not forget to discuss!
barretenberg/cpp/src/barretenberg/vm2/constraining/relations/range_check.test.cpp
Show resolved
Hide resolved
0baa1f1
to
42cae21
Compare
42cae21
to
fb18f3c
Compare
Changes to public function bytecode sizes
🧾 Summary (100% most significant diffs)
Full diff report 👇
|
Also
sel_range_8/16
andpower_of_2
precomputed tables