Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Make public inputs the start of the UH and MH proof #12266

Open
wants to merge 29 commits into
base: master
Choose a base branch
from
Open

feat: Make public inputs the start of the UH and MH proof #12266

wants to merge 29 commits into from
+2,321 −2,505

Conversation

lucasxia01
Copy link
Contributor

Please read contributing guidelines and remove this line.

Base automatically changed from lx/transcript-allow-hashing-without-sending to master February 25, 2025 22:18
@lucasxia01 lucasxia01 marked this pull request as ready for review February 26, 2025 14:45
@Maddiaa0
Copy link
Member

Question, if there is no offset anymore can it just be removed? What was it for ?

@lucasxia01
Copy link
Contributor Author

Question, if there is no offset anymore can it just be removed? What was it for ?

No its still there in the vk, just not redundantly in the proof. The pub_inputs_offset basically represents the number of ecc_ops. I'm not sure if it needs to exist anymore if we don't use MegaHonk with an unstructured trace.

@lucasxia01 lucasxia01 self-assigned this Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lucasxia01 lucasxia01

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucasxia01 @Maddiaa0