-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: PXE oracle refactor #12410
Open
Thunkar
wants to merge
10
commits into
master
Choose a base branch
from
gj/pxe_oracle_refactor
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
chore: PXE oracle refactor #12410
+379
−469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benesjan
approved these changes
Mar 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lovely improvement. Feel free to merge once you address my comments
yarn-project/pxe/src/pxe_data_provider/pxe_data_provider.test.ts
Outdated
Show resolved
Hide resolved
yarn-project/simulator/src/private/unconstrained_execution_oracle.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to address PXE's structural problems, but mostly renaming:
PrivateExecutionOracle
(formerlyClientExecutionContext
) andUnconstrainedExecutionOracle
(formerlyViewDataOracle
). The private execution oracle inherits from the unconstrained one, since that's how our execution model works (private can do all the things unconstrained can plus more)ContractDataOracle
has been substituted byContractDataProvider
. In short, it's just a cache layer + merkle tree constructor that provides contract information to both the execution oracles and the kernel oracle, so I think it's a lot more accurate now.DBOracle
interface is dead. Like the others, it's called nowExecutionDataProvider
since it's a layer that the actual Private and Unconstrained oracles require to answer oracle calls, retrieving and sending info through it as necessary.SimulatorOracle
is dead. It's replacement is calledPXEDataProvider
, implementing theExecutionDataProvider
interface the simulator oracles need to do their thing. This one just happens to be PXE's implementation, which receives PXE's db, the node and a bunch of other things in order to work.AztecNode
, it's NO LONGER PROVIDED to the simulator oracles. All the data oracles require must be provided via theExecutionDataProvider
, which forces this interface to implement part of the node (but I think it's cleaner like this)