Skip to content

Commit

Permalink
Fixes empty parameters for amba service hook and email contact (#1818)
Browse files Browse the repository at this point in the history
  • Loading branch information
arjenhuitema authored Nov 5, 2024
1 parent 548bb1d commit 7749691
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions docs/wiki/Whats-new.md
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ Here's what's changed in Enterprise Scale/Azure Landing Zones:

- Resolved a bug in the Portal Accelerator related to deploying the single platform subscription setup. Incorrect parameter settings led to the failure of AMBA, as it erroneously attempted to deploy to a standard management group structure instead of a single platform management group as needed.
- Increasing Policy assignment delay by a couple of minutes to help reduce assignment errors using the portal accelerator experience (the infamous "please wait 30 minutes and try again" error).
- An issue with the Portal Accelerator regarding the Azure Monitor Baseline Alerts notifications settings was resolved. The problem occurred when no Email Address or Service Hook was specified on the Baseline alerts and monitoring tab. In this scenario, an empty string was converted to an array, resulting in the format `[""]` instead of `[]`. This caused errors during the remediation of the Notification Assets initiative.

### September 2024

Expand Down
4 changes: 2 additions & 2 deletions eslzArm/eslzArm.json
Original file line number Diff line number Diff line change
Expand Up @@ -2268,7 +2268,7 @@
"value": "[parameters('userAssignedManagedIdentityName')]"
},
"ALZWebhookServiceUri": {
"value": "[array(parameters('ambaAgServiceHook'))]"
"value": "[if(empty(parameters('ambaAgServiceHook')), null(), array(parameters('ambaAgServiceHook')))]"
},
"ALZArmRoleId": {
"value": "[array(parameters('ambaAgArmRole'))]"
Expand All @@ -2283,7 +2283,7 @@
"value": "[deployment().location]"
},
"ALZMonitorActionGroupEmail": {
"value": "[array(parameters('ambaAgEmailContact'))]"
"value": "[if(empty(parameters('ambaAgEmailContact')), null(), array(parameters('ambaAgEmailContact')))]"
},
"managementSubscriptionId": {
"value": "[parameters('managementSubscriptionId')]"
Expand Down

0 comments on commit 7749691

Please sign in to comment.