Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AMBA Enhanced Feature Portal Update #1751

Merged
merged 50 commits into from
Sep 3, 2024
Merged

AMBA Enhanced Feature Portal Update #1751

merged 50 commits into from
Sep 3, 2024

Conversation

Springstone
Copy link
Member

@Springstone Springstone commented Aug 30, 2024 •
edited
Loading

Overview/Summary

This pull request includes significant updates to the eslzArm/eslz-portal.json file, focusing on enhancing the Azure Monitor Baseline Alerts (AMBA) configuration and improving user guidance on deploying these alerts.

Enhancements to Azure Monitor Baseline Alerts (AMBA):

  • Added a new section for Azure Monitor Baseline Alerts (AMBA) with a description and a link to more information. (eslzArm/eslz-portal.json)
  • Added a new section for resource category alert enablement, allowing selective enablement of AMBA for specific resource categories such as Azure Arc-enabled Servers, Key Management Services, and Load Balancing Services. (eslzArm/eslz-portal.json)

Improvements to User Guidance:

  • Renamed and updated the enableMonitorBaselines option group to enableServiceHealth, including updated labels and tooltips to provide clearer guidance on deploying Service Health Alerts. (eslzArm/eslz-portal.json)
  • Reintroduced the enableMonitorBaselines option group with updated labels and tooltips to guide users on enabling Azure Monitor Baseline Alerts. (eslzArm/eslz-portal.json)

Azure Public

Deploy To Azure

Springstone and others added 30 commits February 16, 2024 15:54
@Springstone
Add options for enabling Service Health Alerts and configure Action G…
3f7b484 
…roup
@Springstone
.
687985b
@Springstone
.
bcf9688
@Springstone
Add action group notification options
33222cd
@Springstone
Add enableServiceHeatlh parameter to ARM template
dcb37b1
@Springstone
Update Web Hook and ARM Role URIs for action group notifications
a95053f
@Springstone
.
025cee3
@Springstone
.
ad6e53a
@Springstone
.
bb12b3a
@Springstone
.
fb217aa
@Springstone
.
24c64e4
@Springstone
Update tooltips and descriptions for action group notifications
ac09a6d
@Springstone
Update ARM role default values in ESLZ portal JSON
99c04b6
@Springstone
Update ESLZ portal JSON with user assigned managed identity field
802a12c
@Springstone
Update ESLZ portal JSON with user assigned managed identity field
ad989ea
@Springstone
Update ESLZ portal JSON with user assigned managed identity field
437f037
@Springstone
Update ESLZ portal JSON with improved action group notification confi…
617b2b0 
…guration
@Springstone
Merge branch 'main' of https://github.com/Azure/Enterprise-Scale into…
d9e1487 
… AMBAPortalUpdate
@Springstone
Update ESLZ portal JSON with simplified email validation logic
fa96be2
@Springstone
Using AMBA Dev Branch
bde10ca
@Springstone
Merge branch 'main' of https://github.com/Springstone/Enterprise-Scale …
e09e616 
…into AMBAPortalUpdate
@Springstone
Update ESLZ portal JSON to use an array for "ambaAgArmRole" type
1014b46
@Springstone
Update ESLZ portal JSON to use an array for "ambaAgArmRole" type
6b85da6
@Springstone
Update ESLZ portal JSON to remove "enableServiceHealth" parameter
5cd5030
@Springstone
Update ESLZ portal JSON to use an array for "ambaAgArmRole" type
57f010c
@Springstone
.
436243f
@Springstone
.
277dbf9
@Springstone
Update ESLZ portal JSON to add resource specific alert enablement sec…
e7c9e93 
…tion
@Springstone
Update ESLZ portal JSON to add resource specific alert enablement sec…
effac6d 
…tion
@Springstone
Update ESLZ portal JSON to use an array for "ambaAgEmailContact" para…
af470d7 
…meter
@Springstone Springstone added PR: Safe to test 🧪 PRs can run more advanced tests that may deploy or access environments Status: Do Not Merge ⛔ Do not merge PRs with this label attached as they are not ready etc. labels Aug 30, 2024
@Springstone Springstone requested a review from a team as a code owner August 30, 2024 12:42
arjenhuitema
arjenhuitema reviewed Aug 30, 2024
View reviewed changes
Copy link
Contributor

@arjenhuitema arjenhuitema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested the AMBA settings and it deploys correctly.

@Springstone Springstone removed the Status: Do Not Merge ⛔ Do not merge PRs with this label attached as they are not ready etc. label Sep 2, 2024
@Springstone Springstone added the Status: Do Not Merge ⛔ Do not merge PRs with this label attached as they are not ready etc. label Sep 2, 2024
@Springstone Springstone removed the Status: Do Not Merge ⛔ Do not merge PRs with this label attached as they are not ready etc. label Sep 2, 2024
@Springstone Springstone changed the title AMBA New Feature Portal Update AMBA Enhanced Feature Portal Update Sep 2, 2024
@jtracey93 jtracey93 merged commit 8c951ac into Azure:main Sep 3, 2024
3 of 4 checks passed
@Springstone Springstone deleted the AMBAPortalUpdate branch November 5, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arjenhuitema arjenhuitema arjenhuitema left review comments

@jtracey93 jtracey93 jtracey93 approved these changes

Assignees
No one assigned
Labels
PR: Safe to test 🧪 PRs can run more advanced tests that may deploy or access environments
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Springstone @arjenhuitema @jtracey93