Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: LITE DNS Deployment #1753

Merged
merged 9 commits into from
Sep 2, 2024
Merged

Update: LITE DNS Deployment #1753

merged 9 commits into from
Sep 2, 2024

Conversation

brsteph
Copy link
Contributor

@brsteph brsteph commented Aug 30, 2024

Overview/Summary

A bug was found in #1752 where if you deploy a single region, single subscription with DNS zones, the logic for the DNS zone assignment would trigger it to connect the DNS zones to the hub network trice. The cause was due to the conditional logic using defaults that, even if you selected single region, could still be evaluated. This was changed to use the "binary" Yes/No for the secondary region for evaluation, which matches what was in the multi-subscription deployment.

This PR fixes/adds/changes/removes

  1. Changed the ESLITE deployment to use the enableSecondaryRegion property.

Breaking Changes

  1. None

Testing Evidence

Before:

image

After:

image

Testing URLs

Azure Public

[Deploy To Azure](https://portal.azure.com/#blade/Microsoft_Azure_CreateUIDef/CustomDeploymentBlade/uri/https%3A%2F%2Fraw.githubusercontent.com%2F{YOUR GITHUB ORG/ACCOUNT HERE - Remove Curly Brackets Also}%2FEnterprise-Scale%2F{YOUR GITHUB BRANCH NAME HERE - Remove Curly Brackets Also}%2FeslzArm%2FeslzArm.json/uiFormDefinitionUri/https%3A%2F%2Fraw.githubusercontent.com%2F{YOUR GITHUB ORG/ACCOUNT HERE - Remove Curly Brackets Also}%2FEnterprise-Scale%2F{YOUR GITHUB BRANCH NAME HERE - Remove Curly Brackets Also}%2FeslzArm%2Feslz-portal.json)

Azure US Gov (Fairfax)

N/A

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Ensured contribution guidance is followed.
  • Updated relevant and associated documentation.
  • Updated the "What's New?" wiki page (located: /docs/wiki/whats-new.md)

@brsteph brsteph requested a review from a team as a code owner August 30, 2024 17:25
@jtracey93 jtracey93 merged commit 953316f into Azure:main Sep 2, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug Report - Private DNS link failure when using "Single" Platform subscription
3 participants