-
Notifications
You must be signed in to change notification settings - Fork 987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AVNM #1803
Merged
Merged
AVNM #1803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctivity Hub deployment
jtracey93
requested changes
Jan 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @Springstone just a small amount of comments
microsoft-github-policy-service
bot
added
Needs: Author Feedback
and removed
Needs: Author Feedback
labels
Jan 9, 2025
jtracey93
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview/Summary
This pull request introduces a new feature to deploy Azure Virtual Network Manager (AVNM) in the ESLZ deployment templates. The most important changes include adding a new parameter for AVNM deployment, updating deployment conditions and dependencies, and modifying the portal configuration to include AVNM options.
New Feature: Deploy Azure Virtual Network Manager (AVNM)
eslzArm/eslz-portal.json
: Added a new checkbox option for deploying AVNM in the portal configuration. This includes thedeployAVNM
parameter in the connectivity steps. [1] [2]eslzArm/eslzArm.json
: Introduced a newdeployAVNM
parameter with boolean type and default value. Updated deployment conditions and dependencies to include AVNM. Added AVNM connectivity hub URI and deployment name variables. [1] [2] [3] [4] [5]Script Enhancement
eslzArm/prerequisites/ds-prereqs.ps1
: Added a new parameter for ESLZ root name and registered the Microsoft.Network resource provider with the specified ESLZ root.Azure Public