Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix 'az aks nodepool upgrade' cannot set 'node-soak-duration' to 0 #8443

Merged
merged 3 commits into from
Feb 7, 2025
Merged

fix 'az aks nodepool upgrade' cannot set 'node-soak-duration' to 0 #8443

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eda1c25
fix az aks nodepool upgrade cannot set node-soak-duration to 0
Jan 28, 2025
88ea430
check node_soak_duration is int
Feb 6, 2025
d0c0394
update setup.py version
Feb 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/aks-preview/HISTORY.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@ If there is no rush to release a new version, please just add a description of t

To release a new version, please select a new version number (usually plus 1 to last patch version, X.Y.Z -> Major.Minor.Patch, more details in `\doc <https://semver.org/>`_), and then add a new section named as the new version number in this file, the content should include the new modifications and everything from the *Pending* section. Finally, update the `VERSION` variable in `setup.py` with this new version number.

13.0.0b3
+++++++
* Fix `az aks nodepool upgrade` command cannot set `--node-soak-duration` to 0

13.0.0b2
+++++++
* `az aks create/update`: Update advanced container networking service (acns) with 2024-09-02-preview API version enablement.
Expand Down
2 changes: 1 addition & 1 deletion src/aks-preview/azext_aks_preview/custom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1433,7 +1433,7 @@ def aks_agentpool_upgrade(cmd,
instance.upgrade_settings.max_surge = max_surge
if drain_timeout:
instance.upgrade_settings.drain_timeout_in_minutes = drain_timeout
if node_soak_duration:
if node_soak_duration >= 0:
zjpjack-github marked this conversation as resolved.
Show resolved Hide resolved
instance.upgrade_settings.node_soak_duration_in_minutes = node_soak_duration
if undrainable_node_behavior:
instance.upgrade_settings.undrainable_node_behavior = undrainable_node_behavior
Expand Down
Loading