-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AppService] functionapp create
: Check if storage account is network restricted
#30605
Open
kamperiadis
wants to merge
7
commits into
Azure:dev
Choose a base branch
from
kamperiadis:networkrestrictedstorage
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+51,047
−23,622
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
3a4ff40
Throw exception for consumption app creation if network restricted st…
kamperiadis 3e91f3b
Rerun unit tests
kamperiadis 38a2ac7
Prevent creation with network restricted storage unless vnet integrat…
kamperiadis f3384cf
Create file share when creating app with network restricted storage
kamperiadis 9156908
Create file share only when storage acct network restricted, and run …
kamperiadis c84cd74
Resolve merge conflicts
kamperiadis fa3dfb9
Rerun unit tests
kamperiadis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2,350 changes: 1,172 additions & 1,178 deletions
2,350
.../cli/command_modules/appservice/tests/latest/recordings/test_acr_create_function_app.yaml
Large diffs are not rendered by default.
Oops, something went wrong.
2,070 changes: 1,334 additions & 736 deletions
2,070
.../command_modules/appservice/tests/latest/recordings/test_acr_deployment_function_app.yaml
Large diffs are not rendered by default.
Oops, something went wrong.
2,303 changes: 1,229 additions & 1,074 deletions
2,303
...command_modules/appservice/tests/latest/recordings/test_acr_integration_function_app.yaml
Large diffs are not rendered by default.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this function may cause the dismatch between resource name and the recording file.
azure-cli/src/azure-cli/azure/cli/command_modules/appservice/custom.py
Lines 5425 to 5430 in c84cd74
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @yanzhudd We actually do intend to create a new content share resource with a new name on behalf of the customer. Does this mean we should just make the tests run live? Or what would you require for this PR to be merged?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, you can mark the tests as live only, and please remove the related recording files as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @yanzhudd Those tests are already marked as live_only and there are no recording files for them.