{Compute} az sig share: Migrate command group to aaz based
#30606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
|
Hi @cxznmhdcxz, |
❌AzureCLI-BreakingChangeTest
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
|
microsoft-github-policy-service
bot
requested review from
yonzhan,
zhoxing-ms and
yanzhudd
microsoft-github-policy-service
bot
added
the
Compute
cxznmhdcxz
force-pushed
the
sig-share-migrate
branch
from
7f1db15 to
0ddfb39
Compare
yanzhudd
changed the title
az sig share: Migrate command group to aaz basedaz sig share: Migrate command group to aaz based
|
Please remove the unused codes from custom.py. |
|
Please check if the detected breaking changes would actually break customers' usage or not: |
yanzhudd
reviewed
Jan 6, 2025
yanzhudd
reviewed
Jan 6, 2025
src/azure-cli/azure/cli/command_modules/vm/operations/sig_share.py
Outdated
Show resolved
Hide resolved
yanzhudd
reviewed
Jan 6, 2025
src/azure-cli/azure/cli/command_modules/vm/operations/sig_share.py
Outdated
Show resolved
Hide resolved
|
|
Please resolve the CI issue. |
|
Please rerun some related tests in live mode to verify the changes. |
cxznmhdcxz
force-pushed
the
sig-share-migrate
branch
from
33b830a to
89cfcde
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
yanzhudd
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az sig share add/reset/remove/enable-community/waitDescription
Migrate command group to aaz based code
aaz pr Azure/aaz#667
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.