Remove unused includes (#6209)

* Remove unused includes * Fixes * move statics instantiation into cpp * clang-format --------- Co-authored-by: Anton Kolesnyk <[email protected]>
Azure · Nov 14, 2024 · 384552a · 384552a
1 parent 5b841ca
commit 384552a
Show file tree

Hide file tree

Showing 29 changed files with 35 additions and 84 deletions.
diff --git a/sdk/attestation/azure-security-attestation/src/attestation_administration_client.cpp b/sdk/attestation/azure-security-attestation/src/attestation_administration_client.cpp
@@ -3,7 +3,6 @@
 
 #include "azure/attestation/attestation_administration_client.hpp"
 
-#include "azure/attestation/attestation_client.hpp"
 #include "private/attestation_client_models_private.hpp"
 #include "private/attestation_client_private.hpp"
 #include "private/attestation_common_request.hpp"
@@ -12,7 +11,6 @@
 
 #include <azure/core/base64.hpp>
 #include <azure/core/http/policies/policy.hpp>
-#include <azure/core/internal/diagnostics/log.hpp>
 #include <azure/core/internal/http/pipeline.hpp>
 
 #include <shared_mutex>
@@ -28,7 +26,6 @@ using namespace Azure::Core::Http;
 using namespace Azure::Core::Http::Policies;
 using namespace Azure::Core::Http::Policies::_internal;
 using namespace Azure::Core::Http::_internal;
-using namespace Azure::Core::Diagnostics::_internal;
 using namespace Azure::Core::Diagnostics;
 using namespace Azure::Core::_internal;
 

diff --git a/sdk/attestation/azure-security-attestation/src/attestation_client.cpp b/sdk/attestation/azure-security-attestation/src/attestation_client.cpp
@@ -3,7 +3,6 @@
 
 #include "azure/attestation/attestation_client.hpp"
 
-#include "azure/attestation/attestation_administration_client.hpp"
 #include "private/attestation_client_models_private.hpp"
 #include "private/attestation_client_private.hpp"
 #include "private/attestation_common_request.hpp"
@@ -13,7 +12,6 @@
 #include <azure/core/base64.hpp>
 #include <azure/core/credentials/credentials.hpp>
 #include <azure/core/http/policies/policy.hpp>
-#include <azure/core/internal/diagnostics/log.hpp>
 #include <azure/core/internal/http/pipeline.hpp>
 
 #include <shared_mutex>

diff --git a/sdk/attestation/azure-security-attestation/src/private/attestation_client_private.cpp b/sdk/attestation/azure-security-attestation/src/private/attestation_client_private.cpp
@@ -12,8 +12,6 @@
 
 #include <azure/core/internal/json/json.hpp>
 
-#include <chrono>
-#include <memory>
 #include <sstream>
 #include <string>
 #include <vector>

diff --git a/sdk/attestation/azure-security-attestation/src/private/attestation_deserializers_private.cpp b/sdk/attestation/azure-security-attestation/src/private/attestation_deserializers_private.cpp
@@ -19,14 +19,10 @@
 #include "jsonhelpers_private.hpp"
 
 #include <azure/core/base64.hpp>
-#include <azure/core/context.hpp>
 #include <azure/core/http/http.hpp>
-#include <azure/core/internal/http/pipeline.hpp>
 #include <azure/core/internal/json/json.hpp>
 #include <azure/core/internal/json/json_optional.hpp>
-#include <azure/core/internal/json/json_serializable.hpp>
 #include <azure/core/nullable.hpp>
-#include <azure/core/response.hpp>
 
 #include <memory>
 #include <string>

diff --git a/sdk/attestation/azure-security-attestation/src/private/jsonhelpers.cpp b/sdk/attestation/azure-security-attestation/src/private/jsonhelpers.cpp
@@ -14,13 +14,9 @@
 #include "jsonhelpers_private.hpp"
 
 #include <azure/core/base64.hpp>
-#include <azure/core/datetime.hpp>
 #include <azure/core/internal/json/json.hpp>
-#include <azure/core/internal/json/json_optional.hpp>
-#include <azure/core/internal/json/json_serializable.hpp>
 #include <azure/core/nullable.hpp>
 
-#include <memory>
 #include <string>
 #include <vector>
 

diff --git a/sdk/core/azure-core/src/http/transport_policy.cpp b/sdk/core/azure-core/src/http/transport_policy.cpp
@@ -2,7 +2,6 @@
 // Licensed under the MIT License.
 
 #include "azure/core/http/policies/policy.hpp"
-#include "azure/core/platform.hpp"
 
 #if defined(BUILD_CURL_HTTP_TRANSPORT_ADAPTER)
 #include "azure/core/http/curl_transport.hpp"

diff --git a/sdk/core/azure-core/src/resource_identifier.cpp b/sdk/core/azure-core/src/resource_identifier.cpp
@@ -4,7 +4,6 @@
 #include "azure/core/resource_identifier.hpp"
 
 #include <stdexcept>
-#include <string>
 
 namespace {
 const std::string SubscriptionStart = "/subscriptions/";

diff --git a/sdk/eventhubs/azure-messaging-eventhubs/src/consumer_client.cpp b/sdk/eventhubs/azure-messaging-eventhubs/src/consumer_client.cpp
@@ -6,7 +6,6 @@
 #include "private/package_version.hpp"
 
 #include <azure/core/amqp/internal/message_receiver.hpp>
-#include <azure/core/platform.hpp>
 #include <azure/messaging/eventhubs.hpp>
 
 using namespace Azure::Core::Diagnostics::_internal;

diff --git a/sdk/eventhubs/azure-messaging-eventhubs/src/event_data.cpp b/sdk/eventhubs/azure-messaging-eventhubs/src/event_data.cpp
@@ -9,9 +9,7 @@
 #include <azure/core/diagnostics/logger.hpp>
 #include <azure/core/internal/diagnostics/log.hpp>
 
-#include <iomanip>
 #include <iostream>
-#include <sstream>
 
 using namespace Azure::Core::Diagnostics::_internal;
 using namespace Azure::Core::Diagnostics;

diff --git a/sdk/keyvault/azure-security-keyvault-certificates/CMakeLists.txt b/sdk/keyvault/azure-security-keyvault-certificates/CMakeLists.txt
@@ -60,12 +60,12 @@ set(
 set(
   AZURE_KEYVAULT_CERTIFICATES_SOURCE
     src/certificate_client.cpp
+    src/certificate_client_models.cpp
     src/certificate_client_operations.cpp
     src/certificate_client_paged_response.cpp
     src/certificate_serializers.cpp
     src/keyvault_certificates_common_request.cpp
     src/private/certificate_constants.hpp
-    src/private/certificate_key_usage.hpp
     src/private/certificate_serializers.hpp
     src/private/keyvault_certificates_common_request.hpp
     src/private/package_version.hpp

diff --git a/sdk/keyvault/azure-security-keyvault-certificates/src/certificate_client.cpp b/sdk/keyvault/azure-security-keyvault-certificates/src/certificate_client.cpp
@@ -10,7 +10,6 @@
 #include "private/keyvault_certificates_common_request.hpp"
 #include "private/package_version.hpp"
 
-#include <azure/core/base64.hpp>
 #include <azure/core/credentials/credentials.hpp>
 #include <azure/core/http/http.hpp>
 #include <azure/core/http/policies/policy.hpp>

diff --git a/sdk/keyvault/azure-security-keyvault-certificates/src/certificate_client_models.cpp b/sdk/keyvault/azure-security-keyvault-certificates/src/certificate_client_models.cpp
@@ -0,0 +1,34 @@
+// Copyright (c) Microsoft Corporation.
+// Licensed under the MIT License.
+
+#include "azure/keyvault/certificates/certificate_client_models.hpp"
+
+#include "private/certificate_constants.hpp"
+
+using namespace Azure::Security::KeyVault::Certificates;
+
+const CertificateKeyUsage CertificateKeyUsage::DigitalSignature(_detail::DigitalSignatureValue);
+const CertificateKeyUsage CertificateKeyUsage::NonRepudiation(_detail::NonRepudiationValue);
+const CertificateKeyUsage CertificateKeyUsage::KeyEncipherment(_detail::KeyEnciphermentValue);
+const CertificateKeyUsage CertificateKeyUsage::DataEncipherment(_detail::DataEnciphermentValue);
+const CertificateKeyUsage CertificateKeyUsage::KeyAgreement(_detail::KeyAgreementValue);
+const CertificateKeyUsage CertificateKeyUsage::KeyCertSign(_detail::KeyCertSignValue);
+const CertificateKeyUsage CertificateKeyUsage::CrlSign(_detail::CrlSignValue);
+const CertificateKeyUsage CertificateKeyUsage::EncipherOnly(_detail::EncipherOnlyValue);
+const CertificateKeyUsage CertificateKeyUsage::DecipherOnly(_detail::DecipherOnlyValue);
+
+const CertificateKeyType CertificateKeyType::Ec(_detail::EcValue);
+const CertificateKeyType CertificateKeyType::EcHsm(_detail::EcHsmValue);
+const CertificateKeyType CertificateKeyType::Rsa(_detail::RsaValue);
+const CertificateKeyType CertificateKeyType::RsaHsm(_detail::RsaHsmValue);
+
+const CertificateKeyCurveName CertificateKeyCurveName::P256(_detail::P256Value);
+const CertificateKeyCurveName CertificateKeyCurveName::P256K(_detail::P256KValue);
+const CertificateKeyCurveName CertificateKeyCurveName::P384(_detail::P384Value);
+const CertificateKeyCurveName CertificateKeyCurveName::P521(_detail::P521Value);
+
+const CertificateContentType CertificateContentType::Pkcs12(_detail::Pkc12Value);
+const CertificateContentType CertificateContentType::Pem(_detail::PemValue);
+
+const CertificatePolicyAction CertificatePolicyAction::AutoRenew(_detail::AutoRenewValue);
+const CertificatePolicyAction CertificatePolicyAction::EmailContacts(_detail::EmailContactsValue);
diff --git a/sdk/keyvault/azure-security-keyvault-certificates/src/certificate_serializers.cpp b/sdk/keyvault/azure-security-keyvault-certificates/src/certificate_serializers.cpp
@@ -5,7 +5,6 @@
 
 #include "azure/keyvault/certificates/certificate_client_models.hpp"
 #include "private/certificate_constants.hpp"
-#include "private/certificate_key_usage.hpp"
 
 #include <azure/core/base64.hpp>
 #include <azure/core/internal/json/json.hpp>

diff --git a/...eyvault/azure-security-keyvault-certificates/src/keyvault_certificates_common_request.cpp b/...eyvault/azure-security-keyvault-certificates/src/keyvault_certificates_common_request.cpp
@@ -3,8 +3,6 @@
 
 #include "private/keyvault_certificates_common_request.hpp"
 
-#include "private/certificate_constants.hpp"
-
 #include <azure/core/exception.hpp>
 #include <azure/core/http/http.hpp>
 

diff --git a/sdk/keyvault/azure-security-keyvault-certificates/src/private/certificate_key_usage.hpp b/sdk/keyvault/azure-security-keyvault-certificates/src/private/certificate_key_usage.hpp
diff --git a/sdk/keyvault/azure-security-keyvault-keys/src/cryptography/decrypt_parameters.cpp b/sdk/keyvault/azure-security-keyvault-keys/src/cryptography/decrypt_parameters.cpp
@@ -8,7 +8,6 @@
 #include <azure/core/base64.hpp>
 
 #include <string>
-#include <vector>
 
 namespace Azure {
   namespace Security {

diff --git a/sdk/keyvault/azure-security-keyvault-keys/src/cryptography/decrypt_result.cpp b/sdk/keyvault/azure-security-keyvault-keys/src/cryptography/decrypt_result.cpp
@@ -9,7 +9,6 @@
 #include <azure/core/internal/json/json.hpp>
 
 #include <string>
-#include <vector>
 
 using namespace Azure::Core::_internal;
 using namespace Azure::Core::Json::_internal;

diff --git a/sdk/keyvault/azure-security-keyvault-keys/src/cryptography/encrypt_parameters.cpp b/sdk/keyvault/azure-security-keyvault-keys/src/cryptography/encrypt_parameters.cpp
@@ -8,7 +8,6 @@
 #include <azure/core/base64.hpp>
 
 #include <string>
-#include <vector>
 
 namespace Azure {
   namespace Security {

diff --git a/sdk/keyvault/azure-security-keyvault-keys/src/cryptography/key_sign_parameters.cpp b/sdk/keyvault/azure-security-keyvault-keys/src/cryptography/key_sign_parameters.cpp
@@ -9,7 +9,6 @@
 #include <azure/core/base64.hpp>
 
 #include <string>
-#include <vector>
 
 namespace Azure {
   namespace Security {

diff --git a/sdk/keyvault/azure-security-keyvault-keys/src/cryptography/key_wrap_parameters.cpp b/sdk/keyvault/azure-security-keyvault-keys/src/cryptography/key_wrap_parameters.cpp
@@ -3,12 +3,10 @@
 
 #include "../private/cryptography_serializers.hpp"
 #include "../private/key_constants.hpp"
-#include "azure/keyvault/keys/cryptography/cryptography_client_models.hpp"
 
 #include <azure/core/base64.hpp>
 
 #include <string>
-#include <vector>
 
 namespace Azure {
   namespace Security {

diff --git a/sdk/keyvault/azure-security-keyvault-keys/src/cryptography/sign_result.cpp b/sdk/keyvault/azure-security-keyvault-keys/src/cryptography/sign_result.cpp
@@ -9,7 +9,6 @@
 #include <azure/core/internal/json/json.hpp>
 
 #include <string>
-#include <vector>
 
 using namespace Azure::Core::_internal;
 using namespace Azure::Core::Json::_internal;

diff --git a/sdk/keyvault/azure-security-keyvault-keys/src/cryptography/wrap_result.cpp b/sdk/keyvault/azure-security-keyvault-keys/src/cryptography/wrap_result.cpp
@@ -9,7 +9,6 @@
 #include <azure/core/internal/json/json.hpp>
 
 #include <string>
-#include <vector>
 
 using namespace Azure::Core::_internal;
 using namespace Azure::Core::Json::_internal;

diff --git a/sdk/keyvault/azure-security-keyvault-keys/src/key_backup.cpp b/sdk/keyvault/azure-security-keyvault-keys/src/key_backup.cpp
@@ -3,8 +3,6 @@
 
 #include "private/key_backup.hpp"
 
-#include "private/key_constants.hpp"
-
 #include <azure/core/base64.hpp>
 #include <azure/core/internal/json/json.hpp>
 #include <azure/core/internal/json/json_optional.hpp>

diff --git a/sdk/keyvault/azure-security-keyvault-keys/src/key_client_paged_responses.cpp b/sdk/keyvault/azure-security-keyvault-keys/src/key_client_paged_responses.cpp
@@ -9,7 +9,6 @@
 #include <azure/core/internal/json/json.hpp>
 #include <azure/core/internal/json/json_optional.hpp>
 #include <azure/core/internal/json/json_serializable.hpp>
-#include <azure/core/url.hpp>
 
 using namespace Azure::Security::KeyVault::Keys;
 using namespace Azure::Core::Json::_internal;

diff --git a/sdk/keyvault/azure-security-keyvault-keys/src/key_get_random_bytes.cpp b/sdk/keyvault/azure-security-keyvault-keys/src/key_get_random_bytes.cpp
@@ -7,7 +7,6 @@
 
 #include <azure/core/base64.hpp>
 #include <azure/core/internal/json/json.hpp>
-#include <azure/core/internal/json/json_optional.hpp>
 
 using namespace Azure::Security::KeyVault::Keys;
 using namespace Azure::Core::Json::_internal;

diff --git a/sdk/keyvault/azure-security-keyvault-keys/src/key_release_policy.cpp b/sdk/keyvault/azure-security-keyvault-keys/src/key_release_policy.cpp
@@ -5,12 +5,9 @@
 #include "private/key_constants.hpp"
 #include "private/key_serializers.hpp"
 
-#include <azure/core/base64.hpp>
 #include <azure/core/internal/json/json_optional.hpp>
 
-#include <map>
 #include <string>
-#include <vector>
 
 using namespace Azure::Security::KeyVault::Keys;
 using namespace Azure::Core::_internal;

diff --git a/sdk/keyvault/azure-security-keyvault-keys/src/key_type.cpp b/sdk/keyvault/azure-security-keyvault-keys/src/key_type.cpp
@@ -4,8 +4,6 @@
 #include "azure/keyvault/keys/key_client_models.hpp"
 #include "private/key_constants.hpp"
 
-#include <stdexcept>
-
 using namespace Azure::Security::KeyVault::Keys;
 
 const KeyVaultKeyType KeyVaultKeyType::Ec(_detail::EcValue);

diff --git a/sdk/keyvault/azure-security-keyvault-keys/src/keyvault_key.cpp b/sdk/keyvault/azure-security-keyvault-keys/src/keyvault_key.cpp
@@ -8,7 +8,6 @@
 #include <azure/core/internal/json/json.hpp>
 #include <azure/core/internal/json/json_optional.hpp>
 #include <azure/core/internal/json/json_serializable.hpp>
-#include <azure/core/url.hpp>
 
 using namespace Azure::Security::KeyVault::Keys;
 using namespace Azure::Core::Json::_internal;

diff --git a/sdk/keyvault/azure-security-keyvault-keys/src/recover_deleted_key_operation.cpp b/sdk/keyvault/azure-security-keyvault-keys/src/recover_deleted_key_operation.cpp
@@ -3,7 +3,6 @@
 
 #include "azure/keyvault/keys/key_client.hpp"
 #include "azure/keyvault/keys/key_client_models.hpp"
-#include "private/key_constants.hpp"
 #include "private/key_serializers.hpp"
 
 #include <azure/core/exception.hpp>