Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move KV Keys to pyproject.toml #39100

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Move KV Keys to pyproject.toml #39100

wants to merge 12 commits into from

Conversation

lmazuel
Copy link
Member

@lmazuel lmazuel commented Jan 9, 2025

No description provided.

@lmazuel lmazuel requested a review from scbedd January 9, 2025 21:43
@lmazuel lmazuel requested a review from mccoyp as a code owner January 9, 2025 21:43
scbedd added 2 commits January 9, 2025 15:49
@scbedd
temporarily continue on error from twine verify readme so we can see …
6afd03d 
…the rest of the failures
@scbedd
cleaning up remaining references to setup.py. it is mostly as simple …
bd25f43 
…as removing the assumed setup.py in favor of just using the package directory
@lmazuel lmazuel mentioned this pull request Jan 10, 2025
Open
scbedd added 2 commits January 10, 2025 14:00
@scbedd
repair mindependency
187298d
@scbedd
ensure that build failures are checked in create_package, add build t…
2e76671 
…o the set of dependencies that are installed (so that installing pure pyproject.toml packages does not fail). this repairs the depends tox environment
@scbedd
Copy link
Member

scbedd commented Jan 10, 2025 •
edited
Loading

Just going to edit this comment here to highlight discovered issues that aren't readily available in the pullrequest pipeline.

  • Fix mindependency/latestdependency crashes
  • Fix depends crash
  • Add build to default dependencies for all of tox (so that create_package when invoked for local packages won't crash on pure pyproject.toml)
  • Enable nightly alpha update for requirements (if the azure requirement doesn't exist on pypi, we update it with the alpha suffix so that the nightly scheduled internal feed builds will match the latest alpha version)
    • Our requirement updater isn't tightly bound to setup.py! Wonder of wonders I don't need to make any changes!

swathipil
swathipil reviewed Jan 27, 2025
View reviewed changes
Copy link
Member

@swathipil swathipil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: Adding a build folder to azure-keyvault-keys and building the wheel from this results in a wheel with a build folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swathipil swathipil swathipil left review comments

@scbedd scbedd Awaiting requested review from scbedd scbedd is a code owner

@mccoyp mccoyp Awaiting requested review from mccoyp mccoyp is a code owner

@weshaggard weshaggard Awaiting requested review from weshaggard weshaggard is a code owner

@benbp benbp Awaiting requested review from benbp benbp is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
KeyVault
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lmazuel @scbedd @swathipil