Add support for Mariner Arm64 docker image distribution. #2891
+95
−89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dphulkar-msft
requested review from
gapra-msft,
adreed-msft,
vibhansa-msft,
seanmcc-msft,
souravgupta-msft and
tanyasethi-msft
as code owners
|
Can we hold off on merging this until the release pipeline is migrated to OneBranch? |
gapra-msft
reviewed
Dec 18, 2024
wonwuakpa-msft
approved these changes
Dec 20, 2024
…into dphulkar/dockerMarinerArm64Support
gapra-msft
reviewed
Jan 13, 2025
|
|
||
| - ${{ if eq(parameters.jobName, 'Set_2_Ubuntu_Mariner_ARM64') }}: | ||
| - script: | | ||
| sudo apt update |
There was a problem hiding this comment.
We can probably do this for all the cases, this should be safe to do even in the distros that we didn't need this for
gapra-msft
reviewed
Jan 13, 2025
| ./dockerinstall.sh | ||
|
|
||
| # Build and publish Docker containers | ||
| ./buildcontainer.sh Dockerfile ${{ parameters.ubuntu_tag }} |
There was a problem hiding this comment.
Shouldn't the Dockerfile names be passed in as an arg? Same with Mariner below
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for Mariner Arm64 docker image distribution. Added a template file for docker build and publish.
Feature / Bug Fix: (Brief description of the feature or issue being addressed)
Related Links:
Issues
Team thread
Documents
[Email Subject]
Type of Change
How Has This Been Tested?
Thank you for your contribution to AzCopy!