CreateTimer validation and more context for activity implementations #1183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add CreateTimer input validation: the design of the
CreateTimerAPI makes it easy to accidentally pass aCancellationTokenas thestateparameter, which is never appropriate and is also theoretically dangerous because of how cancellation token deserialization can corrupt memory. This PR adds validation ensuring that the API is not being used incorrectly.Add more context for activities: General enhancement to allow activities to know their name, version, and task ID. This can be useful for debugging and logging purposes. It can also be used for simplifying the implementation of some versioning scenarios.
Incremented DurableTask.Core package version to 3.1.0.