Skip to content

Commit

Permalink
Linting
Browse files Browse the repository at this point in the history
  • Loading branch information
jaredfholgate committed Sep 12, 2024
1 parent 47dc7cf commit b581c57
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 34 deletions.
29 changes: 9 additions & 20 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,17 @@ Things to do:

1. Set up a GitHub repo environment called `test`.
1. Configure environment protection rule to ensure that approval is required before deploying to this environment.
1. Install Docker Desktop to run tests
1. Create a user-assigned managed identity in your test subscription.
1. Create a role assignment for the managed identity on your test subscription, use the minimum required role.
1. Configure federated identity credentials on the user assigned managed identity. Use the GitHub environment.
1. Search and update TODOs within the code and remove the TODO comments once complete.

> [!IMPORTANT]
> Modules **MUST NOT** be published at version `1.0.0` or higher at this time. All module **MUST** be published as versions (e.g., `0.1.0`, `0.1.1`, `0.2.0`, etc.).
> We plan to allow `v1.0.0` in the coming months.
> This delay is to ensure there will be no futher changes to the specifications that would result in breaking changes.
> As the overall AVM framework is not GA (generally available) yet - the CI framework and test automation is not fully functional and implemented across all supported languages yet - breaking changes are expected, and additional customer feedback is yet to be gathered and incorporated. Hence, modules **MUST NOT** be published at version `1.0.0` or higher at this time.
>
> AVM modules are suitable for use in production (unless specified otherwise on the module's repo).
> All module **MUST** be published as a pre-release version (e.g., `0.1.0`, `0.1.1`, `0.2.0`, etc.) until the AVM framework becomes GA.
>
> However, it is important to note that this **DOES NOT** mean that the modules cannot be consumed and utilized. They **CAN** be leveraged in all types of environments (dev, test, prod etc.). Consumers can treat them just like any other IaC module and raise issues or feature requests against them as they learn from the usage of the module. Consumers should also read the release notes for each version, if considering updating to a more recent version of a module to see if there are any considerations or breaking changes etc.
<!-- markdownlint-disable MD033 -->
## Requirements
Expand All @@ -29,16 +32,6 @@ The following requirements are needed by this module:

- <a name="requirement_random"></a> [random](#requirement\_random) (~> 3.5)

## Providers

The following providers are used by this module:

- <a name="provider_azurerm"></a> [azurerm](#provider\_azurerm) (~> 3.71)

- <a name="provider_modtm"></a> [modtm](#provider\_modtm) (~> 0.3)

- <a name="provider_random"></a> [random](#provider\_random) (~> 3.5)

## Resources

The following resources are used by this module:
Expand Down Expand Up @@ -294,10 +287,6 @@ The following outputs are exported:

Description: A map of the private endpoints created.

### <a name="output_resource"></a> [resource](#output\_resource)

Description: This is the full output for the resource.

## Modules

No modules.
Expand All @@ -306,4 +295,4 @@ No modules.
## Data Collection

The software may collect information about you and your use of the software and send it to Microsoft. Microsoft may use this information to provide services and improve our products and services. You may turn off the telemetry as described in the repository. There are also some features in the software that may enable you and Microsoft to collect data from users of your applications. If you use these features, you must comply with applicable law, including providing appropriate notices to users of your applications together with a copy of Microsoft’s privacy statement. Our privacy statement is located at <https://go.microsoft.com/fwlink/?LinkID=824704>. You can learn more about data collection and use in the help documentation and our privacy statement. Your use of the software operates as your consent to these practices.
<!-- END_TF_DOCS -->
<!-- END_TF_DOCS -->
16 changes: 4 additions & 12 deletions examples/default/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@ provider "azurerm" {
## Section to provide a random Azure region for the resource group
# This allows us to randomize the region for the resource group.
module "regions" {
source = "Azure/regions/azurerm"
version = "~> 0.3"
source = "Azure/avm-utl-regions/azurerm"
version = "~> 0.1"
}
# This allows us to randomize the region for the resource group.
Expand Down Expand Up @@ -82,14 +82,6 @@ The following requirements are needed by this module:

- <a name="requirement_random"></a> [random](#requirement\_random) (~> 3.5)

## Providers

The following providers are used by this module:

- <a name="provider_azurerm"></a> [azurerm](#provider\_azurerm) (~> 3.74)

- <a name="provider_random"></a> [random](#provider\_random) (~> 3.5)

## Resources

The following resources are used by this module:
Expand Down Expand Up @@ -132,9 +124,9 @@ Version: ~> 0.3

### <a name="module_regions"></a> [regions](#module\_regions)

Source: Azure/regions/azurerm
Source: Azure/avm-utl-regions/azurerm

Version: ~> 0.3
Version: ~> 0.1

### <a name="module_test"></a> [test](#module\_test)

Expand Down
2 changes: 0 additions & 2 deletions outputs.tf
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,3 @@ output "private_endpoints" {
DESCRIPTION
value = var.private_endpoints_manage_dns_zone_group ? azurerm_private_endpoint.this_managed_dns_zone_groups : azurerm_private_endpoint.this_unmanaged_dns_zone_groups
}

# https://azure.github.io/Azure-Verified-Modules/specs/terraform/#id-tffr2---category-outputs---additional-terraform-outputs

0 comments on commit b581c57

Please sign in to comment.