Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: container run as current user #114

Merged
merged 7 commits into from
May 16, 2024
Merged

Conversation

matt-FFFFFF
Copy link
Member

@matt-FFFFFF matt-FFFFFF commented May 13, 2024

DO NOT MERGE until https://github.com/Azure/tfmod-scaffold/tags is >= 0.56

Confirmed ready to go

Adds support for container running as current user, preventing permissions errors.

@matt-FFFFFF matt-FFFFFF added enhancement New feature or request and removed Needs: Triage 🔍 labels May 14, 2024
@matt-FFFFFF matt-FFFFFF marked this pull request as draft May 14, 2024 14:49
@matt-FFFFFF
Copy link
Member Author

matt-FFFFFF commented May 14, 2024

Please hold off

Ready

@matt-FFFFFF matt-FFFFFF marked this pull request as ready for review May 16, 2024 10:10
Copy link
Member

@lonegunmanb lonegunmanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @matt-FFFFFF

@matt-FFFFFF matt-FFFFFF merged commit 40f689e into main May 16, 2024
9 checks passed
@matt-FFFFFF matt-FFFFFF deleted the feat/container-non-root-user branch May 16, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants