Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Global setup teardown #176

Merged
merged 34 commits into from
Jan 15, 2025
Merged

Global setup teardown #176

merged 34 commits into from
Jan 15, 2025

Conversation

lonegunmanb
Copy link
Member

Description

Type of Change

  • Non-module change (e.g. CI/CD, documentation, etc.)
  • Azure Verified Module updates:
    • Bugfix containing backwards compatible bug fixes
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates.
    • Breaking changes.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • I did run all pre-commit checks

@lonegunmanb
add globalsetup and globalteardown jobs in test-examples-template.yml
e0ad1a1
@lonegunmanb
add environment to global setup and teardown
c9dc27f
@lonegunmanb
cd into examples when execute setup.sh and teardown.sh
7de69ea
@lonegunmanb
add ARM_OIDC_REQUEST_TOKEN=true env var
e77a530
@lonegunmanb
trigger ci
12fbc79
@lonegunmanb
try to map credentio into setup and teardown script
9332852
@lonegunmanb
debug
f9047c0
@lonegunmanb
debug
1d73870
@lonegunmanb
use docker to execute setup and teardown scripts
a4ff6bb
@lonegunmanb
debug
408700f
@lonegunmanb
debug
a51d4b7
@lonegunmanb
debug
ec078d4
@lonegunmanb
update all steps, use reusable prepare-credential.sh
6e70d96
@lonegunmanb
correct shell script file name
5b612b3
@lonegunmanb
correct prepare script
d4765c9
@lonegunmanb
correct prepare script
096e0d0
@lonegunmanb
bypass globalsetup and globalteardown if there's no such files
78037b5
@lonegunmanb
correct script
fd03ad4
@lonegunmanb
correct script
bb3cfb7
@lonegunmanb
correct script
468249b
@lonegunmanb
correct if condition for testexamplescomplete
3a48678
@lonegunmanb
correct if condition for testexamplescomplete
7ad0bfd
@lonegunmanb
correct if condition for testexamplescomplete
218321a
@lonegunmanb
correct if condition for testexamplescomplete
63a911b
@lonegunmanb
update if condition for checkteardown, otherwise it would be skipped …
ecac96c 
…if globalsetup has been skipped.
@lonegunmanb
don't run testexamplescomplete when testexamples failed
705e289
@lonegunmanb
don't run testexamplescomplete when testexamples failed
78f8aed
@lonegunmanb
fail testexamplescomplete when testexamples failed
289bdcd
@lonegunmanb
set fail-fast to false and remove continue-on-error on testexamples
da9744e
@lonegunmanb
remove fail-fast
d81df05
jaredfholgate
jaredfholgate approved these changes Jan 6, 2025
View reviewed changes
Copy link
Member

@jaredfholgate jaredfholgate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me, not tested in any depth, but can verify once it is merged.

@lonegunmanb lonegunmanb merged commit 19c93d1 into Azure:main Jan 15, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredfholgate jaredfholgate jaredfholgate approved these changes

Assignees
No one assigned
Labels
Needs: Triage 🔍
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lonegunmanb @jaredfholgate