Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update terraform.tf #90

Merged
merged 2 commits into from
Mar 13, 2024
Merged

Update terraform.tf #90

merged 2 commits into from
Mar 13, 2024

Conversation

JFolberth
Copy link
Contributor

Update min versions
@segraef
Copy link
Contributor

segraef commented Mar 6, 2024

Was this agreed with @matt-FFFFFF since your change removes the major version constraint?

@matt-FFFFFF
Copy link
Member

This is fine, it's just another way of writing the same thing.

@lonegunmanb
Copy link
Member

I don't think we need this pr for this template. I understand that @JFolberth want this change because the change he'd like to introduce in Azure/terraform-azurerm-avm-res-managedidentity-userassignedidentity#1 (review) require this min versions restriction, but they're not required by all AVM repos. Each AVM repo could keep it's own provider versions restriction, but I think it's better to keep a loose restriction here in the template repo, otherwise enforcing a high version requirement could block our users from using some AVM modules. WDYT @JFolberth @matt-FFFFFF ?

@JFolberth
Copy link
Contributor Author

I have no preference either way. Was just closing the loop on feedback from the module I was working on if it was something that should be addressed back to the template level.

@lonegunmanb lonegunmanb merged commit af3114c into Azure:main Mar 13, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants