Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add use azapi option for subscription creation. #253

Merged
merged 8 commits into from
Sep 27, 2023
Merged

feat: add use azapi option for subscription creation. #253

merged 8 commits into from
Sep 27, 2023

Conversation

luke-taylor
Copy link
Contributor

@luke-taylor luke-taylor commented Sep 14, 2023

Overview/summary

Replace this with a brief description of what this Pull Request fixes, changes, etc.

This PR fixes/adds/changes/removes

This allows a user to create a subscription alias and associate it to a management group using entirely the AzApi as opposed to azurerm. This may be preferable when not wanting to assign privileged permissions to the default management group of the tenant.

Breaking changes

No breaking changes.

Testing evidence

Associated to MG.
image
Not Associated to MG
image
Local Go TestSubscription*:
image

As part of this pull request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Run and make fmt & make docs to format your code and update documentation.
  • Created unit and deployment tests and provided evidence.
  • Updated relevant and associated documentation.

@luke-taylor luke-taylor requested a review from a team as a code owner September 14, 2023 15:25
@luke-taylor luke-taylor changed the title Feat: Add Use AzApi Option for Subscription Creation. feat: Add Use AzApi Option for Subscription Creation. Sep 14, 2023
@luke-taylor luke-taylor changed the title feat: Add Use AzApi Option for Subscription Creation. feat: add use azapi option for subscription creation. Sep 14, 2023
@matt-FFFFFF matt-FFFFFF self-assigned this Sep 27, 2023
@matt-FFFFFF matt-FFFFFF added the PR: Safe to test 🧪 PRs can run deployment tests label Sep 27, 2023
@matt-FFFFFF matt-FFFFFF temporarily deployed to CSUTF-RO September 27, 2023 11:14 — with GitHub Actions Inactive
@matt-FFFFFF matt-FFFFFF temporarily deployed to CSUTF-RO September 27, 2023 11:14 — with GitHub Actions Inactive
@matt-FFFFFF matt-FFFFFF temporarily deployed to CSUTF-RO September 27, 2023 11:14 — with GitHub Actions Inactive
@matt-FFFFFF matt-FFFFFF temporarily deployed to CSUTF-RO September 27, 2023 11:14 — with GitHub Actions Inactive
@matt-FFFFFF matt-FFFFFF temporarily deployed to CSUTF-RO September 27, 2023 11:14 — with GitHub Actions Inactive
@matt-FFFFFF matt-FFFFFF temporarily deployed to CSUTF-RO September 27, 2023 11:14 — with GitHub Actions Inactive
@matt-FFFFFF matt-FFFFFF temporarily deployed to CSUTF-RO September 27, 2023 11:14 — with GitHub Actions Inactive
@matt-FFFFFF matt-FFFFFF temporarily deployed to CSUTF-RO September 27, 2023 11:14 — with GitHub Actions Inactive
@matt-FFFFFF matt-FFFFFF added this pull request to the merge queue Sep 27, 2023
Merged via the queue into Azure:main with commit a3ed5b6 Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Safe to test 🧪 PRs can run deployment tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants