-
Notifications
You must be signed in to change notification settings - Fork 18
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #336 from B3Partners/issue#332
Testcase voor verwerking CVs in BRK
- Loading branch information
Showing
3 changed files
with
440 additions
and
16 deletions.
There are no files selected for viewing
332 changes: 332 additions & 0 deletions
332
brmo-loader/src/test/java/nl/b3p/Mantis6380IntegrationTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,332 @@ | ||
| /* | ||
| * Copyright (C) 2017 B3Partners B.V. | ||
| */ | ||
| package nl.b3p; | ||
|
|
||
| import java.io.File; | ||
| import java.io.FileInputStream; | ||
| import java.util.concurrent.locks.Lock; | ||
| import java.util.concurrent.locks.ReentrantLock; | ||
| import nl.b3p.brmo.loader.BrmoFramework; | ||
| import nl.b3p.brmo.loader.jdbc.OracleConnectionUnwrapper; | ||
| import nl.b3p.brmo.test.util.database.JTDSDriverBasedFailures; | ||
| import nl.b3p.brmo.test.util.database.dbunit.CleanUtil; | ||
| import org.apache.commons.dbcp.BasicDataSource; | ||
| import org.apache.commons.logging.Log; | ||
| import org.apache.commons.logging.LogFactory; | ||
| import org.dbunit.database.DatabaseConfig; | ||
| import org.dbunit.database.DatabaseConnection; | ||
| import org.dbunit.database.DatabaseDataSourceConnection; | ||
| import org.dbunit.database.IDatabaseConnection; | ||
| import org.dbunit.dataset.IDataSet; | ||
| import org.dbunit.dataset.ITable; | ||
| import org.dbunit.dataset.xml.XmlDataSet; | ||
| import org.dbunit.ext.mssql.InsertIdentityOperation; | ||
| import org.dbunit.ext.mssql.MsSqlDataTypeFactory; | ||
| import org.dbunit.ext.oracle.Oracle10DataTypeFactory; | ||
| import org.dbunit.ext.postgresql.PostgresqlDataTypeFactory; | ||
| import org.dbunit.operation.DatabaseOperation; | ||
| import org.junit.After; | ||
| import static org.junit.Assert.assertEquals; | ||
| import static org.junit.Assert.assertNull; | ||
| import static org.junit.Assert.assertTrue; | ||
| import static org.junit.Assume.assumeTrue; | ||
| import org.junit.Before; | ||
| import org.junit.Test; | ||
| import org.junit.experimental.categories.Category; | ||
|
|
||
| /** | ||
| * Testcases voor mantis-6380 / GH#332; incorrect verwerken van commanditair | ||
| * vennootschap rechten in mutatie. Draaien met: | ||
| * {@code mvn -Dit.test=Mantis6380IntegrationTest -Dtest.onlyITs=true verify -Poracle > target/oracle.log} | ||
| * voor bijvoorbeeld Oracle of | ||
| * {@code mvn -Dit.test=Mantis6380IntegrationTest -Dtest.onlyITs=true verify -Ppostgresql > target/postgresql.log}. | ||
| * <strong>NB.</strong> werkt niet op mssql, althans niet met de jTDS driver | ||
| * omdat die geen JtdsPreparedStatement#setNull() methode heeft. | ||
| * | ||
| * @author mprins | ||
| */ | ||
| @Category(JTDSDriverBasedFailures.class) | ||
| public class Mantis6380IntegrationTest extends AbstractDatabaseIntegrationTest { | ||
|
|
||
| private static final Log LOG = LogFactory.getLog(Mantis6380IntegrationTest.class); | ||
|
|
||
| private BrmoFramework brmo; | ||
|
|
||
| private IDatabaseConnection rsgb; | ||
| private IDatabaseConnection staging; | ||
|
|
||
| private final Lock sequential = new ReentrantLock(); | ||
|
|
||
| @Override | ||
| @Before | ||
| public void setUp() throws Exception { | ||
| BasicDataSource dsStaging = new BasicDataSource(); | ||
| dsStaging.setUrl(params.getProperty("staging.jdbc.url")); | ||
| dsStaging.setUsername(params.getProperty("staging.user")); | ||
| dsStaging.setPassword(params.getProperty("staging.passwd")); | ||
| dsStaging.setAccessToUnderlyingConnectionAllowed(true); | ||
|
|
||
| BasicDataSource dsRsgb = new BasicDataSource(); | ||
| dsRsgb.setUrl(params.getProperty("rsgb.jdbc.url")); | ||
| dsRsgb.setUsername(params.getProperty("rsgb.user")); | ||
| dsRsgb.setPassword(params.getProperty("rsgb.passwd")); | ||
| dsRsgb.setAccessToUnderlyingConnectionAllowed(true); | ||
|
|
||
| rsgb = new DatabaseDataSourceConnection(dsRsgb); | ||
| staging = new DatabaseDataSourceConnection(dsStaging); | ||
|
|
||
| if (this.isMsSQL) { | ||
| rsgb.getConfig().setProperty(DatabaseConfig.PROPERTY_DATATYPE_FACTORY, new MsSqlDataTypeFactory()); | ||
| staging.getConfig().setProperty(DatabaseConfig.PROPERTY_DATATYPE_FACTORY, new MsSqlDataTypeFactory()); | ||
| } else if (this.isOracle) { | ||
| rsgb = new DatabaseConnection(OracleConnectionUnwrapper.unwrap(dsRsgb.getConnection()), params.getProperty("rsgb.user").toUpperCase()); | ||
| rsgb.getConfig().setProperty(DatabaseConfig.PROPERTY_DATATYPE_FACTORY, new Oracle10DataTypeFactory()); | ||
| rsgb.getConfig().setProperty(DatabaseConfig.FEATURE_SKIP_ORACLE_RECYCLEBIN_TABLES, true); | ||
| staging = new DatabaseConnection(OracleConnectionUnwrapper.unwrap(dsStaging.getConnection()), params.getProperty("staging.user").toUpperCase()); | ||
| staging.getConfig().setProperty(DatabaseConfig.PROPERTY_DATATYPE_FACTORY, new Oracle10DataTypeFactory()); | ||
| staging.getConfig().setProperty(DatabaseConfig.FEATURE_SKIP_ORACLE_RECYCLEBIN_TABLES, true); | ||
| } else if (this.isPostgis) { | ||
| // we hebben alleen nog postgres over | ||
| rsgb.getConfig().setProperty(DatabaseConfig.PROPERTY_DATATYPE_FACTORY, new PostgresqlDataTypeFactory()); | ||
| staging.getConfig().setProperty(DatabaseConfig.PROPERTY_DATATYPE_FACTORY, new PostgresqlDataTypeFactory()); | ||
| } | ||
|
|
||
| IDataSet stagingDataSet = new XmlDataSet(new FileInputStream(new File(Mantis6380IntegrationTest.class.getResource("/mantis6380/staging.xml").toURI()))); | ||
|
|
||
| sequential.lock(); | ||
|
|
||
| if (this.isMsSQL) { | ||
| InsertIdentityOperation.CLEAN_INSERT.execute(staging, stagingDataSet); | ||
| } else { | ||
| DatabaseOperation.CLEAN_INSERT.execute(staging, stagingDataSet); | ||
| } | ||
| brmo = new BrmoFramework(dsStaging, dsRsgb); | ||
|
|
||
| // skip als de bron data er niet is | ||
| assumeTrue("Er zijn geen 2 STAGING_OK berichten", 2l == brmo.getCountBerichten(null, null, "brk", "STAGING_OK")); | ||
| assumeTrue("Er zijn geen 2 STAGING_OK laadproces", 2l == brmo.getCountLaadProcessen(null, null, "brk", "STAGING_OK")); | ||
| } | ||
|
|
||
| @After | ||
| public void cleanup() throws Exception { | ||
| brmo.closeBrmoFramework(); | ||
|
|
||
| CleanUtil.cleanRSGB_BRK(rsgb, true); | ||
| rsgb.close(); | ||
|
|
||
| CleanUtil.cleanSTAGING(staging); | ||
| staging.close(); | ||
|
|
||
| sequential.unlock(); | ||
| } | ||
|
|
||
| @Test | ||
| public void testTransformStand() throws Exception { | ||
| brmo.setOrderBerichten(false); | ||
| Thread t = brmo.toRsgb(); | ||
| t.join(); | ||
|
|
||
| assertEquals("Niet alle berichten zijn OK getransformeerd", 1l, brmo.getCountBerichten(null, null, "brk", "STAGING_OK")); | ||
| assertEquals("Niet alle berichten zijn OK getransformeerd", 1l, brmo.getCountBerichten(null, null, "brk", "RSGB_OK")); | ||
| assertEquals("Er zijn berichten met status RSGB_NOK", 0l, brmo.getCountBerichten(null, null, "brk", "RSGB_NOK")); | ||
|
|
||
| ITable kad_onrrnd_zk = rsgb.createDataSet().getTable("kad_onrrnd_zk"); | ||
| assertEquals("Aantal actuele onroerende zaken is incorrect", 1, kad_onrrnd_zk.getRowCount()); | ||
|
|
||
| ITable kad_perceel = rsgb.createDataSet().getTable("kad_perceel"); | ||
| assertEquals("Aantal actuele percelen is incorrect", 1, kad_perceel.getRowCount()); | ||
| assertEquals("Perceel identif is incorrect", "37640054270000", kad_perceel.getValue(0, "sc_kad_identif").toString()); | ||
|
|
||
| ITable subject = rsgb.createDataSet().getTable("subject"); | ||
| assertEquals("Aantal subjecten klopt niet", 1, subject.getRowCount()); | ||
|
|
||
| ITable ingeschr_niet_nat_prs = rsgb.createDataSet().getTable("ingeschr_niet_nat_prs"); | ||
| assertEquals("Aantal ingeschr_niet_nat_prs klopt niet", 1, ingeschr_niet_nat_prs.getRowCount()); | ||
|
|
||
| ITable zak_recht = rsgb.createDataSet().getTable("zak_recht"); | ||
| assertEquals("Aantal zakelijke rechten klopt niet", 2, zak_recht.getRowCount()); | ||
| // rij 1 | ||
| assertEquals("NL.KAD.Tenaamstelling.AKR1.100000007757634", zak_recht.getValue(0, "kadaster_identif").toString()); | ||
| assertEquals("1", zak_recht.getValue(0, "ar_noemer").toString()); | ||
| assertEquals("1", zak_recht.getValue(0, "ar_teller").toString()); | ||
| // rij 2 | ||
| assertEquals("NL.KAD.ZakelijkRecht.AKR1.100000007757634", zak_recht.getValue(1, "kadaster_identif").toString()); | ||
| assertNull("noemer is niet null", zak_recht.getValue(1, "ar_noemer")); | ||
| assertNull("teller is niet null", zak_recht.getValue(1, "ar_teller")); | ||
| } | ||
|
|
||
| /** | ||
| * transformeer alle berichten en test of dat correct is gedaan. | ||
| * | ||
| * @throws Exception if any | ||
| */ | ||
| @Test | ||
| public void testTransformBerichten() throws Exception { | ||
| brmo.setOrderBerichten(true); | ||
| Thread t = brmo.toRsgb(); | ||
| t.join(); | ||
|
|
||
| assertEquals("Niet alle berichten zijn OK getransformeerd", 0l, brmo.getCountBerichten(null, null, "brk", "STAGING_OK")); | ||
| assertEquals("Niet alle berichten zijn OK getransformeerd", 2l, brmo.getCountBerichten(null, null, "brk", "RSGB_OK")); | ||
| assertEquals("Er zijn berichten met status RSGB_NOK", 0l, brmo.getCountBerichten(null, null, "brk", "RSGB_NOK")); | ||
|
|
||
| ITable brondocument = rsgb.createDataSet().getTable("brondocument"); | ||
| assertTrue("Er zijn geen brondocumenten", brondocument.getRowCount() > 0); | ||
|
|
||
| ITable kad_onrrnd_zk = rsgb.createDataSet().getTable("kad_onrrnd_zk"); | ||
| assertEquals("Aantal actuele onroerende zaken is incorrect", 1, kad_onrrnd_zk.getRowCount()); | ||
|
|
||
| ITable kad_perceel = rsgb.createDataSet().getTable("kad_perceel"); | ||
| assertEquals("Aantal actuele percelen is incorrect", 1, kad_perceel.getRowCount()); | ||
| assertEquals("Perceel identif is incorrect", "37640054270000", kad_perceel.getValue(0, "sc_kad_identif").toString()); | ||
|
|
||
| ITable subject = rsgb.createDataSet().getTable("subject"); | ||
| assertEquals("Aantal subjecten klopt niet", 3, subject.getRowCount()); | ||
|
|
||
| ITable ingeschr_niet_nat_prs = rsgb.createDataSet().getTable("ingeschr_niet_nat_prs"); | ||
| assertEquals("Aantal ingeschr_niet_nat_prs klopt niet", 3, ingeschr_niet_nat_prs.getRowCount()); | ||
|
|
||
| ITable zak_recht = rsgb.createDataSet().getTable("zak_recht"); | ||
| assertEquals("Aantal zakelijke rechten klopt niet", 3, zak_recht.getRowCount()); | ||
| // rij 1 | ||
| assertEquals("NL.KAD.Tenaamstelling.AKR1.100000012798492", zak_recht.getValue(0, "kadaster_identif").toString()); | ||
| assertEquals("6", zak_recht.getValue(0, "ar_teller").toString()); | ||
| assertEquals("25", zak_recht.getValue(0, "ar_noemer").toString()); | ||
| // rij 2 | ||
| assertEquals("NL.KAD.Tenaamstelling.AKR1.100000012798558", zak_recht.getValue(1, "kadaster_identif").toString()); | ||
| assertEquals("19", zak_recht.getValue(1, "ar_teller").toString()); | ||
| assertEquals("25", zak_recht.getValue(1, "ar_noemer").toString()); | ||
| // rij 3 | ||
| assertEquals("NL.KAD.ZakelijkRecht.AKR1.100000007757634", zak_recht.getValue(2, "kadaster_identif").toString()); | ||
| assertNull("teller is niet null", zak_recht.getValue(2, "ar_teller")); | ||
| assertNull("noemer is niet null", zak_recht.getValue(2, "ar_noemer")); | ||
| } | ||
|
|
||
| /** | ||
| * transformeer eerst stand bericht en daarna mutatie bericht en test of dat | ||
| * correct is gedaan. | ||
| * | ||
| * @throws Exception if any | ||
| */ | ||
| @Test | ||
| public void testTransformStandDaarnaMutatieBerichten() throws Exception { | ||
| brmo.setOrderBerichten(false); | ||
| Thread t = brmo.toRsgb(); | ||
| t.join(); | ||
|
|
||
| assertEquals("Niet alle berichten zijn OK getransformeerd", 1l, brmo.getCountBerichten(null, null, "brk", "STAGING_OK")); | ||
| assertEquals("Niet alle berichten zijn OK getransformeerd", 1l, brmo.getCountBerichten(null, null, "brk", "RSGB_OK")); | ||
| assertEquals("Er zijn berichten met status RSGB_NOK", 0l, brmo.getCountBerichten(null, null, "brk", "RSGB_NOK")); | ||
|
|
||
| brmo.setOrderBerichten(true); | ||
| t = brmo.toRsgb(); | ||
| t.join(); | ||
|
|
||
| assertEquals("Niet alle berichten zijn OK getransformeerd", 0l, brmo.getCountBerichten(null, null, "brk", "STAGING_OK")); | ||
| assertEquals("Niet alle berichten zijn OK getransformeerd", 2l, brmo.getCountBerichten(null, null, "brk", "RSGB_OK")); | ||
| assertEquals("Er zijn berichten met status RSGB_NOK", 0l, brmo.getCountBerichten(null, null, "brk", "RSGB_NOK")); | ||
|
|
||
| ITable brondocument = rsgb.createDataSet().getTable("brondocument"); | ||
| assertTrue("Er zijn geen brondocumenten", brondocument.getRowCount() > 0); | ||
|
|
||
| ITable kad_onrrnd_zk = rsgb.createDataSet().getTable("kad_onrrnd_zk"); | ||
| assertEquals("Aantal actuele onroerende zaken is incorrect", 1, kad_onrrnd_zk.getRowCount()); | ||
|
|
||
| ITable kad_perceel = rsgb.createDataSet().getTable("kad_perceel"); | ||
| assertEquals("Aantal actuele percelen is incorrect", 1, kad_perceel.getRowCount()); | ||
| assertEquals("Perceel identif is incorrect", "37640054270000", kad_perceel.getValue(0, "sc_kad_identif").toString()); | ||
|
|
||
| ITable subject = rsgb.createDataSet().getTable("subject"); | ||
| assertEquals("Aantal subjecten klopt niet", 3, subject.getRowCount()); | ||
|
|
||
| ITable ingeschr_niet_nat_prs = rsgb.createDataSet().getTable("ingeschr_niet_nat_prs"); | ||
| assertEquals("Aantal ingeschr_niet_nat_prs klopt niet", 3, ingeschr_niet_nat_prs.getRowCount()); | ||
|
|
||
| ITable zak_recht = rsgb.createDataSet().getTable("zak_recht"); | ||
| assertEquals("Aantal zakelijke rechten klopt niet", 3, zak_recht.getRowCount()); | ||
| // rij 1 | ||
| assertEquals("NL.KAD.Tenaamstelling.AKR1.100000012798492", zak_recht.getValue(0, "kadaster_identif").toString()); | ||
| assertEquals("6", zak_recht.getValue(0, "ar_teller").toString()); | ||
| assertEquals("25", zak_recht.getValue(0, "ar_noemer").toString()); | ||
| // rij 2 | ||
| assertEquals("NL.KAD.Tenaamstelling.AKR1.100000012798558", zak_recht.getValue(1, "kadaster_identif").toString()); | ||
| assertEquals("19", zak_recht.getValue(1, "ar_teller").toString()); | ||
| assertEquals("25", zak_recht.getValue(1, "ar_noemer").toString()); | ||
| // rij 3 | ||
| assertEquals("NL.KAD.ZakelijkRecht.AKR1.100000007757634", zak_recht.getValue(2, "kadaster_identif").toString()); | ||
| assertNull("teller is niet null", zak_recht.getValue(2, "ar_teller")); | ||
| assertNull("noemer is niet null", zak_recht.getValue(2, "ar_noemer")); | ||
| } | ||
|
|
||
| /** | ||
| * transformeer eerst stand bericht, verwijder dat dan en transformeer | ||
| * daarna mutatie bericht en test of dat correct is gedaan. Verwacht een | ||
| * AssertionError omdat het aantal zakelijk rechten dan niet corrrect is | ||
| * (het oude zakelijk recht wordt niet opgeruimd). | ||
| * | ||
| * @throws Exception if any | ||
| */ | ||
| @Test(expected = AssertionError.class) | ||
| public void testTransformDeleteStandDaarnaMutatieBerichten() throws Exception { | ||
| brmo.setOrderBerichten(false); | ||
| Thread t = brmo.toRsgb(); | ||
| t.join(); | ||
|
|
||
| assertEquals("Niet alle berichten zijn OK getransformeerd", 1l, brmo.getCountBerichten(null, null, "brk", "STAGING_OK")); | ||
| assertEquals("Niet alle berichten zijn OK getransformeerd", 1l, brmo.getCountBerichten(null, null, "brk", "RSGB_OK")); | ||
| assertEquals("Er zijn berichten met status RSGB_NOK", 0l, brmo.getCountBerichten(null, null, "brk", "RSGB_NOK")); | ||
|
|
||
| // delete stand bericht | ||
| brmo.delete(1l); | ||
|
|
||
| assertEquals("Niet alle berichten zijn OK getransformeerd", 1l, brmo.getCountBerichten(null, null, "brk", "STAGING_OK")); | ||
| assertEquals("Niet alle berichten zijn OK getransformeerd", 0l, brmo.getCountBerichten(null, null, "brk", "RSGB_OK")); | ||
| assertEquals("Er zijn berichten met status RSGB_NOK", 0l, brmo.getCountBerichten(null, null, "brk", "RSGB_NOK")); | ||
|
|
||
| // transformeer mutatie | ||
| brmo.setOrderBerichten(true); | ||
| t = brmo.toRsgb(); | ||
| t.join(); | ||
|
|
||
| assertEquals("Niet alle berichten zijn OK getransformeerd", 0l, brmo.getCountBerichten(null, null, "brk", "STAGING_OK")); | ||
| assertEquals("Niet alle berichten zijn OK getransformeerd", 1l, brmo.getCountBerichten(null, null, "brk", "RSGB_OK")); | ||
| assertEquals("Er zijn berichten met status RSGB_NOK", 0l, brmo.getCountBerichten(null, null, "brk", "RSGB_NOK")); | ||
|
|
||
| ITable brondocument = rsgb.createDataSet().getTable("brondocument"); | ||
| assertTrue("Er zijn geen brondocumenten", brondocument.getRowCount() > 0); | ||
|
|
||
| ITable kad_onrrnd_zk = rsgb.createDataSet().getTable("kad_onrrnd_zk"); | ||
| assertEquals("Aantal actuele onroerende zaken is incorrect", 1, kad_onrrnd_zk.getRowCount()); | ||
|
|
||
| ITable kad_perceel = rsgb.createDataSet().getTable("kad_perceel"); | ||
| assertEquals("Aantal actuele percelen is incorrect", 1, kad_perceel.getRowCount()); | ||
| assertEquals("Perceel identif is incorrect", "37640054270000", kad_perceel.getValue(0, "sc_kad_identif").toString()); | ||
|
|
||
| ITable subject = rsgb.createDataSet().getTable("subject"); | ||
| assertEquals("Aantal subjecten klopt niet", 3, subject.getRowCount()); | ||
|
|
||
| ITable ingeschr_niet_nat_prs = rsgb.createDataSet().getTable("ingeschr_niet_nat_prs"); | ||
| assertEquals("Aantal ingeschr_niet_nat_prs klopt niet", 3, ingeschr_niet_nat_prs.getRowCount()); | ||
|
|
||
| ITable zak_recht = rsgb.createDataSet().getTable("zak_recht"); | ||
|
|
||
| // fail (met AssertionError), want als het stand bericht is verdwenen is er geen mogelijkheid meer om | ||
| // te achterhalen wat opgeruimd moet worden en wordt de mutatie als stand/nieuw object verwerkt. | ||
| // De oude rechten blijven dan aanwezig - dus 3 + 1 oude | ||
| assertEquals("Aantal zakelijke rechten klopt niet", 3, zak_recht.getRowCount()); | ||
|
|
||
| // rij 1 | ||
| assertEquals("NL.KAD.Tenaamstelling.AKR1.100000012798492", zak_recht.getValue(0, "kadaster_identif").toString()); | ||
| assertEquals("6", zak_recht.getValue(0, "ar_teller").toString()); | ||
| assertEquals("25", zak_recht.getValue(0, "ar_noemer").toString()); | ||
| // rij 2 | ||
| assertEquals("NL.KAD.Tenaamstelling.AKR1.100000012798558", zak_recht.getValue(1, "kadaster_identif").toString()); | ||
| assertEquals("19", zak_recht.getValue(1, "ar_teller").toString()); | ||
| assertEquals("25", zak_recht.getValue(1, "ar_noemer").toString()); | ||
| // rij 3 | ||
| assertEquals("NL.KAD.ZakelijkRecht.AKR1.100000007757634", zak_recht.getValue(2, "kadaster_identif").toString()); | ||
| assertNull("teller is niet null", zak_recht.getValue(2, "ar_teller")); | ||
| assertNull("noemer is niet null", zak_recht.getValue(2, "ar_noemer")); | ||
| } | ||
| } |
Oops, something went wrong.