FIX: Always use buffered producers to allow multiple concurrent flow paths to use the same products #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexanderLontke
approved these changes
Jul 22, 2024
breakbotz
pushed a commit
that referenced
this pull request
Jul 29, 2024
* BUILD: require unit tests and veracode to pass before release * FIX: Always use buffered producers to allow multiple concurrent flow paths to use the same products (#29) * API: make properties source and processor public * API: rename attribute transformer_group to transformer * CODE: mark true start of private definitions section * REFACTOR: make SerialConduit.chained_conduits abstract * REFACTOR: don't use iter_concurrent_conduits in is_valid_source() * REFACTOR: don't use iter_concurrent_conduits in product_type * REFACTOR: don't use iter_concurrent_conduits in is_chained * REFACTOR: don't use iter_concurrent_conduits in FlowGraph * API: replace (a)iter_concurrent_conduits() to …_concurrent_producers() * TEST: add unit test ensuring conduits shared between paths run only once * REFACTOR: move buffered producer classes to _simple.py * DOC: remove obsolete @inheritdoc decorators * BUILD: upgrade mypy to 1.11 * REFACTOR: eliminate aiter_concurrent_producers() * DOC: remove an obsolete inline comment * API: remove SerialTransformer.[a]iter() * REFACTOR: remove obsolete [a]iter_concurrent_conduits() * DOC: update release notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request refactors the concurrent producer and transformer classes to improve the handling of shared conduits.
The refactoring ensures that shared conduits always use buffered producers to allow multiple concurrent flow paths to use the same products without re-producing them, which is essential for efficient concurrent processing.
This PR also removes the (functionally redundant)
iter()andaiter()methods from theSerialTransformerclass. This change simplifies the Transformer API, directing users towards thetransform()andatransform()methods for data processing.The changes include renaming methods for clarity, adding new properties, and updating the logic for iterating over concurrent producers and transformers.
Changes
Method Renaming:
iter_concurrent_conduitstoiter_concurrent_producers.aiter_concurrent_conduitstoaiter_concurrent_producers.Refactored Logic:
_BufferedProducerand_AsyncBufferedProducerclasses more widely to materialize or buffer products and allow concurrent paths use the same product instances where possible.