fix: AB테스트 토큰 발급용 API 추가 #1104
Merged
fix: AB테스트 토큰 발급용 API 추가 #1104
+71
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
songsunkook
requested review from
ImTotem,
Soundbar91,
DHkimgit,
dradnats1012,
20HyeonsuLee,
Choon0414 and
kih1015
Soundbar91
approved these changes
Dec 2, 2024
| @@ -49,7 +49,8 @@ private void excludeGetMapping() { | |||
| + "!execution(* in.koreatech.koin.admin.user.controller.AdminUserController.refresh(..)) && " | |||
| + "!execution(* in.koreatech.koin.admin.user.controller.AdminUserController.createAdmin(..)) && " | |||
| + "!execution(* in.koreatech.koin.admin.user.controller.AdminUserController.adminPasswordChange(..)) && " | |||
| + "!execution(* in.koreatech.koin.admin.abtest.controller.AbtestController.assignOrGetAbtestVariable(..))") | |||
| + "!execution(* in.koreatech.koin.admin.abtest.controller.AbtestController.assignOrGetAbtestVariable(..)) &&" | |||
| + "!execution(* in.koreatech.koin.admin.abtest.controller.AbtestController.issueAccessHistoryId(..))") | |||
There was a problem hiding this comment.
A
처리잘해주셨어요 !!
히스토리 기능은 별도의 어노테이션을 적용해서 개선하는 방향으로 가야겠다는 생각이 이번에 들었네용,,
There was a problem hiding this comment.
어노테이션도 좋은 방향인 것 같아요 👍
로직은 이해를 했는데, 코드 정리의 필요성(?)을 느낀 것 같아요. 리펙토링 계획이 있으신지 궁금합니다 !
당시에는 나름 예쁘다고 생각했는데.. 지금봐도 나름 예쁘다고 생각하는데....... 메서드분리 잘하지않았나... 싶었는데 다들 문제가 있어보인다고 하니 확실히 리팩토링을 해봐야겠네요.. 😥
DB에서 여러번 조회하는 등 문제있는 로직이 분명 존재하는 걸 확인하기도 했으니 방학중으로 날잡고 손보겠습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔥 연관 이슈
🚀 작업 내용
💬 리뷰 중점사항