Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: PUT/v2/timetables/lecture 검증 로직 추가 #1117

Merged
merged 2 commits into from
Dec 4, 2024
Merged

fix: PUT/v2/timetables/lecture 검증 로직 추가 #1117

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
08206ff
fix: TimetableLectureUpdateRequest List필드 검증 어노테이션 추가
Dec 4, 2024
e2a593e
fix: Integer id 검증 추가 및 로직 수정
Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .../java/in/koreatech/koin/domain/timetableV2/dto/request/TimetableLectureUpdateRequest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@

import io.swagger.v3.oas.annotations.media.Schema;
import jakarta.validation.Valid;
import jakarta.validation.constraints.NotEmpty;
import jakarta.validation.constraints.NotNull;
import jakarta.validation.constraints.Size;

Expand All @@ -20,13 +21,14 @@ public record TimetableLectureUpdateRequest(
Integer timetableFrameId,

@Valid
@NotEmpty(message = "시간표 정보를 입력해주세요.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A

Empty 먹히나용 ??

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

네 ㅋㅋ

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿이에요

@Schema(description = "시간표 정보", requiredMode = NOT_REQUIRED)
@NotNull(message = "시간표 정보를 입력해주세요.")
List<InnerTimetableLectureRequest> timetableLecture
) {
@JsonNaming(value = SnakeCaseStrategy.class)
public record InnerTimetableLectureRequest(
@Schema(description = "시간표 강의 id", example = "1", requiredMode = REQUIRED)
@NotNull(message = "강의 id를 입력해주세요.")
Integer id,

@Schema(description = "강의 id", example = "1", requiredMode = NOT_REQUIRED)
Expand Down
Loading