Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 스웨거 그룹 timetableV3 추가 #1158

Merged
merged 2 commits into from
Jan 5, 2025
Merged

feat: 스웨거 그룹 timetableV3 추가 #1158

merged 2 commits into from
Jan 5, 2025

Conversation

kwoo28
Copy link
Contributor

@kwoo28 kwoo28 commented Jan 4, 2025 •
edited
Loading

🔥 연관 이슈

🚀 작업 내용

전 PR에서 누락된 스웨거 그룹에서 timetableV3패키지 경로 추가했습니다.

+controller에서 인터페이스 상속하는걸 깜빡해서 추가했습니다.

💬 리뷰 중점사항

@kwoo28 kwoo28 self-assigned this Jan 4, 2025
@github-actions github-actions bot added the 기능 새로운 기능을 개발합니다. label Jan 4, 2025
Soundbar91
Soundbar91 approved these changes Jan 4, 2025
View reviewed changes
Copy link
Contributor

@Soundbar91 Soundbar91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

그룹화 이거,, 제가 했지만 새로운 API가 나올 때 마다 신경을 써줘야하네요 😢

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 4, 2025 •
edited
Loading

Unit Test Results

344 tests   343 ✔️  1m 27s ⏱️
  42 suites      1 💤
  42 files        0 ❌

Results for commit 055e213.

♻️ This comment has been updated with latest results.

duehee
duehee approved these changes Jan 5, 2025
View reviewed changes
Copy link
Contributor

@duehee duehee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

예리하게 찾아내셨네요 👀

@kwoo28 kwoo28 merged commit 7f08427 into develop Jan 5, 2025
4 checks passed
@kwoo28 kwoo28 deleted the feature/1157-add-timetableV3-swagger branch January 5, 2025 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duehee duehee duehee approved these changes

@Soundbar91 Soundbar91 Soundbar91 approved these changes

@seongjae6751 seongjae6751 Awaiting requested review from seongjae6751

@daheeParkk daheeParkk Awaiting requested review from daheeParkk

Assignees

@kwoo28 kwoo28

Labels
기능 새로운 기능을 개발합니다.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

스웨거 그룹 timetableLectureV3 추가
3 participants
@kwoo28 @Soundbar91 @duehee