feat : 분실물 게시글 API 구현 #1170

Choon0414 · 2025-01-13T16:30:55Z

🔥 연관 이슈

close 분실물 게시글 등록 / 삭제 #1167

🚀 작업 내용

분실물 API를 구현했습니다.
- 분실물 게시글 전체 조회 / 단건 조회 / 작성 / 삭제
- 분실물 게시글 등록 시 키워드 알림이 발송됩니다.
articles 구조
- new_articles
  - new_koreatech_articles (한기대 공지)
  - new_koin_articles (코인 공지)
  - lost_item_articles (분실물 게시판)
    - lost_item_images (분실물 이미지)

💬 리뷰 중점사항

github-actions · 2025-01-13T16:36:39Z

Unit Test Results

354 tests 353 ✔️ 1m 26s ⏱️
  45 suites     1 💤
  45 files     0 ❌

Results for commit 13dc083.

♻️ This comment has been updated with latest results.

kih1015

짧은 시간 내에 작업하시느라 정말 고생많으셨어요

코멘트 몇개만 확인부탁드립니다..!

kih1015 · 2025-01-13T18:20:53Z

src/main/java/in/koreatech/koin/domain/community/article/controller/ArticleController.java

+
+    @GetMapping("/lostitem")


A

정말정말 사소한거긴한데 두개 단어라서 하이픈으로 엮어주면 어떨까요? ex) "lost-item"

저도 이 생각 했어요!

kih1015 · 2025-01-13T18:22:15Z

src/main/java/in/koreatech/koin/domain/community/article/dto/LostItemArticleRequest.java

+@JsonNaming(value = SnakeCaseStrategy.class)
+
+public record LostItemArticleRequest(


A

공백 지워주세용

kih1015 · 2025-01-13T18:28:21Z

src/main/java/in/koreatech/koin/domain/community/article/model/Board.java

    private Board(
+        Integer id,
        String name,
        boolean isAnonymous,
        Integer articleCount,
        boolean isDeleted,
        boolean isNotice,
        Integer parentId
    ) {
+        this.id = id;


A

DB에서 id를 결정하기 때문에 빌더에 id 속성을 안넣어도 되지 않나요?

분실물 게시판 boardId를 14로 정해서 생성 부분 수정하다 놓친 것 같네요.
수정하겠습니다!

kih1015 · 2025-01-13T18:35:56Z

src/main/resources/db/migration/V110__add_lost_item_image_table.sql

+    `author_id`       INT UNSIGNED NULL comment '작성자 id',
+    `category`        VARCHAR(255) NOT NULL comment '분실물 카테고리',
+    `found_place`     VARCHAR(255) NOT NULL comment '습득 장소',
+    `found_date`      VARCHAR(255) NOT NULL comment '습득 날짜',


C

found_date 날짜 타입으로 변경해야할 것 같아요..!

kih1015 · 2025-01-13T19:00:05Z

src/main/java/in/koreatech/koin/domain/community/article/dto/LostItemArticleRequest.java

+    @Schema(description = "분실물 사진")
+    List<String> images,


A

이미지 url 인가요?
클라에서 자원 서버에 직접 저장하고 url만 넘겨주는 형태인건가요?

맞습니다. s3에 저장후 접근할 수 있는 url을 서버로 전달해줍니다.

사용자가 이미지 등록 → 클라이언트는 presigned url을 생성받아 S3에 이미지를 등록
→ S3가 클라이언트에게 해당 이미지의 url을 응답 → 클라가 서버에게 전달

DHkimgit

수고하셨습니다!

DHkimgit · 2025-01-14T03:51:47Z

src/main/java/in/koreatech/koin/domain/community/article/controller/ArticleController.java

+import in.koreatech.koin.domain.community.article.model.Article;
+import in.koreatech.koin.domain.community.article.model.LostItemArticle;


사용 안하는 것 같아요!

DHkimgit · 2025-01-14T03:52:38Z

src/main/java/in/koreatech/koin/domain/community/article/model/Article.java

@@ -14,6 +14,8 @@
 import org.hibernate.annotations.Where;

 import in.koreatech.koin.admin.notice.dto.AdminNoticeRequest;
+import in.koreatech.koin.domain.community.article.dto.LostItemArticleRequest;
+import in.koreatech.koin.domain.community.article.dto.LostItemArticlesRequest;


18번째 줄 사용 안하는 것 같아요

import 부분은 리뷰에서 놓치기 쉬운데 예리한 지적 감사합니다!

dradnats1012

고생하셨습니다!

dradnats1012 · 2025-01-14T03:58:08Z

src/main/java/in/koreatech/koin/domain/community/article/controller/ArticleApi.java

+    @Operation(summary = "분실물 게시글 등록")
+    @PostMapping("/lostitem")
+    ResponseEntity<Void> createLostItemArticle(
+        @Auth(permit = {COUNCIL}) Integer councilId,


요게 총학 @Auth 인가요??

넵 학생회라 COUNCIL로 정했습니다.

dradnats1012 · 2025-01-14T04:00:09Z

src/main/java/in/koreatech/koin/domain/community/article/controller/ArticleApi.java

+    @ApiResponses(
+        value = {
+            @ApiResponse(responseCode = "200"),
+            @ApiResponse(responseCode = "404", content = @Content(schema = @Schema(hidden = true))),
+        }
+    )
+    @Operation(summary = "분실물 게시글 단건 조회")
+    @GetMapping("/{id}")
+    ResponseEntity<LostItemArticleResponse> getLostItemArticle(
+        @Parameter(in = PATH) @PathVariable("id") Integer articleId
+    );


@Operation(summary = "게시글 단건 조회") @GetMapping("/{id}") ResponseEntity<ArticleResponse> getArticle( @RequestParam(required = false) Integer boardId, @Parameter(in = PATH) @PathVariable("id") Integer articleId, @IpAddress String ipAddress );

이 부분이랑 겹치는것 같은데 괜찮은가요??

경로를 수정 안했네요! 감사합니다.

dradnats1012 · 2025-01-14T04:00:40Z

src/main/java/in/koreatech/koin/domain/community/article/controller/ArticleController.java

+
+    @GetMapping("/lostitem")


저도 이 생각 했어요!

Choon0414 added 5 commits January 13, 2025 14:39

feat : 분실물 게시판 구현

00d4f4d

feat : 분실물 게시판 조회/삭제 구현

d53b93f

feat : 키워드 알림 추가

1e21837

refactor: 키워드 알림 수정

0e09eaa

chore : 줄바꿈 수정

097a2f5

Choon0414 added 기능 새로운 기능을 개발합니다. Team Campus 캠퍼스 팀에서 작업할 이슈입니다 labels Jan 13, 2025

Choon0414 requested review from songsunkook, ImTotem, DHkimgit, dradnats1012 and kih1015 January 13, 2025 16:30

Choon0414 self-assigned this Jan 13, 2025

kih1015 approved these changes Jan 13, 2025

View reviewed changes

DHkimgit approved these changes Jan 14, 2025

View reviewed changes

dradnats1012 approved these changes Jan 14, 2025

View reviewed changes

Choon0414 added 3 commits January 14, 2025 13:50

fix: 리뷰 반영

9c7565b

Merge branch 'develop' into feature/1167-lost-item-api

22ae5f7

fix: 리뷰 반영

13dc083

Choon0414 merged commit 774b6e0 into develop Jan 14, 2025
4 checks passed

Choon0414 deleted the feature/1167-lost-item-api branch January 14, 2025 08:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat : 분실물 게시글 API 구현 #1170

feat : 분실물 게시글 API 구현 #1170

Choon0414 commented Jan 13, 2025

github-actions bot commented Jan 13, 2025 •

edited

Loading

kih1015 left a comment

kih1015 Jan 13, 2025

dradnats1012 Jan 14, 2025

kih1015 Jan 13, 2025

kih1015 Jan 13, 2025

Choon0414 Jan 14, 2025

kih1015 Jan 13, 2025 •

edited

Loading

kih1015 Jan 13, 2025

Choon0414 Jan 14, 2025 •

edited

Loading

DHkimgit left a comment

DHkimgit Jan 14, 2025

DHkimgit Jan 14, 2025 •

edited

Loading

Choon0414 Jan 14, 2025

dradnats1012 left a comment

dradnats1012 Jan 14, 2025

Choon0414 Jan 14, 2025 •

edited

Loading

dradnats1012 Jan 14, 2025

Choon0414 Jan 14, 2025 •

edited

Loading

dradnats1012 Jan 14, 2025

		@JsonNaming(value = SnakeCaseStrategy.class)

		public record LostItemArticleRequest(

		@Schema(description = "분실물 사진")
		List<String> images,

		import in.koreatech.koin.domain.community.article.model.Article;
		import in.koreatech.koin.domain.community.article.model.LostItemArticle;

feat : 분실물 게시글 API 구현 #1170

feat : 분실물 게시글 API 구현 #1170

Conversation

Choon0414 commented Jan 13, 2025

🔥 연관 이슈

🚀 작업 내용

💬 리뷰 중점사항

github-actions bot commented Jan 13, 2025 • edited Loading

Unit Test Results

kih1015 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

A

Choose a reason for hiding this comment

Choose a reason for hiding this comment

A

Choose a reason for hiding this comment

A

Choose a reason for hiding this comment

kih1015 Jan 13, 2025 • edited Loading

Choose a reason for hiding this comment

C

Choose a reason for hiding this comment

A

Choon0414 Jan 14, 2025 • edited Loading

Choose a reason for hiding this comment

DHkimgit left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DHkimgit Jan 14, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dradnats1012 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choon0414 Jan 14, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choon0414 Jan 14, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Jan 13, 2025 •

edited

Loading

kih1015 Jan 13, 2025 •

edited

Loading

Choon0414 Jan 14, 2025 •

edited

Loading

DHkimgit Jan 14, 2025 •

edited

Loading

Choon0414 Jan 14, 2025 •

edited

Loading

Choon0414 Jan 14, 2025 •

edited

Loading