Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 권한 추가 및 분실물 게시글 작성 response 수정 #1173

Merged
merged 1 commit into from
Jan 14, 2025
Merged

fix: 권한 추가 및 분실물 게시글 작성 response 수정 #1173

merged 1 commit into from
Jan 14, 2025

Conversation

Choon0414
Copy link
Contributor

🔥 연관 이슈

  • close #이슈번호

🚀 작업 내용

  1. STUDENT 접근 권한의 모든 API에 COUNCIL 권한을 추가하였습니다.
  2. 분실물 게시글 작성 응답을 수정하였습니다.

💬 리뷰 중점사항

@Choon0414 Choon0414 added 버그 정상적으로 동작하지 않는 문제상황입니다. Team Campus 캠퍼스 팀에서 작업할 이슈입니다 labels Jan 14, 2025
@Choon0414 Choon0414 self-assigned this Jan 14, 2025
@github-actions GitHub Actions
Copy link

Unit Test Results

354 tests   353 ✔️  1m 32s ⏱️
  45 suites      1 💤
  45 files        0 ❌

Results for commit 2c49a29.

kih1015
kih1015 approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@kih1015 kih1015 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!

dradnats1012
dradnats1012 approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@dradnats1012 dradnats1012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

총학 계정으로는 분실물 관련만 할텐데 다 추가한 이유가 있나용

@Choon0414
Copy link
Contributor Author

총학 계정으로는 분실물 관련만 할텐데 다 추가한 이유가 있나용

학생 권한이 기본으로 되어있는 API에서 예기치 못한 오류가 생길까 추가했습니다.(ex. 개인정보확인 등)
다른 API쪽 권한은 들은게 없어서 2차 때 논의해서 수정하겠습니다!

@Choon0414 Choon0414 merged commit 1ee828f into develop Jan 14, 2025
5 checks passed
@Choon0414 Choon0414 deleted the fix/alter-lost-item-article-response branch January 14, 2025 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kih1015 kih1015 kih1015 approved these changes

@dradnats1012 dradnats1012 dradnats1012 approved these changes

@songsunkook songsunkook Awaiting requested review from songsunkook

@ImTotem ImTotem Awaiting requested review from ImTotem

@DHkimgit DHkimgit Awaiting requested review from DHkimgit

Assignees

@Choon0414 Choon0414

Labels
Team Campus 캠퍼스 팀에서 작업할 이슈입니다 버그 정상적으로 동작하지 않는 문제상황입니다.
Projects
🏫 TEAM CAMPUS
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Choon0414 @dradnats1012 @kih1015