feat : 학기와 이수구분으로 강의 찾기 #1184
Merged
feat : 학기와 이수구분으로 강의 찾기 #1184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Soundbar91
approved these changes
Jan 19, 2025
src/main/java/in/koreatech/koin/domain/graduation/controller/GraduationApi.java
Outdated
Show resolved
Hide resolved
src/main/java/in/koreatech/koin/domain/graduation/dto/CourseTypeLectureResponse.java
Outdated
Show resolved
Hide resolved
src/main/java/in/koreatech/koin/domain/timetableV2/repository/LectureRepositoryV2.java
Show resolved
Hide resolved
src/main/java/in/koreatech/koin/global/config/swagger/SwaggerGroupConfig.java
Show resolved
Hide resolved
Soundbar91
approved these changes
Jan 20, 2025
src/main/java/in/koreatech/koin/domain/graduation/dto/LecturePortionResponse.java
Outdated
Show resolved
Hide resolved
duehee
merged commit 0527431
into
feature/1140-graduation-credit-calculator
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔥 연관 이슈
🚀 작업 내용
💬 리뷰 중점사항
간단한 로직인데 머리에서 계속 꼬여서 여러 번 해멘 경우..
입력한 학기에서 이수구분을 확인하여 어떤 강의를 들어야하는지 출력하도록 했습니다.
추가적으로 !!!! year 관련된 로직 오류터져서 일단은 주석 처리 해놨습니다. 작업 끝나고 지울게요.
그 외 레포지토리 정리랑 flyway 오류 있어서 수정했습니다. 작업 시 확인해주세요.
로직은 학기(연도+학기)와 이수구분의 이름을 입력받으면 이수구분의 이름으로 이수구분의 아이디를 찾습니다.
이 이수구분의 아이디로 카탈로그에서 모든 강의를 가져옵니다.(현재 좀 무거운데, 중복 처리 된 거 빼면 가벼워 질 것 같습니다.)
카탈로그에서 강의 코드를 가져오고, 입력받은 학기와 강의코드를 통하여 그 학기의 이수구분에 맞는 강의들을 전체 반환합니다.
이상한 점 있으면 말씀해주세요 :D