refactor: 졸업 학점 계산 Catalog 테이블 학과 공통 처리 및 major 우선 로직 반영 #1208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ithub.com/BCSDLab/KOIN_API_V2 into feature/1204-catalog-department-major-handling
seongjae6751
changed the title
duehee
approved these changes
Feb 1, 2025
Soundbar91
approved these changes
Feb 5, 2025
seongjae6751
merged commit c919e83
into
feature/1140-graduation-credit-calculator
3 checks passed
seongjae6751
deleted the
feature/1204-catalog-department-major-handling
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔥 연관 이슈
🚀 작업 내용
1.catalog 테이블을 이용하는 코드 중 catalog 테이블의 major_id를 먼저 확인 후 null이면 department_id를 가져오게 했습니다.
2. year로 같이 조회하게 다시 원상복구 했습니다.
💬 리뷰 중점사항