[픽스] 식단 펼치기 기능 화살표 방향 문제 해결 #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaeseungyun
approved these changes
Sep 27, 2024
| @@ -150,7 +150,7 @@ export default function DiningBlocks({ diningType, date }: DiningBlocksProps) { | |||
| <svg | |||
| className={cn({ | |||
| [styles['arrow-icon']]: true, | |||
| [styles['arrow-icon__transform']]: !hiddenDiningIdList.includes(dining.id), | |||
| [styles['arrow-icon--close']]: !hiddenDiningIdList.includes(dining.id), | |||
Comment on lines
176
to
177
| &--close { | ||
| transform: rotate(0); |
There was a problem hiding this comment.
열을 때처럼 닫힐 때도 transition이 있으면 좋을 것 같아요!
제가 착각했네요... ㅠ 그대로 진행해도 잘 작동하겠군요! 👍
There was a problem hiding this comment.
PR 스크린샷을 잘못 올려서 수정하였습니다 !
Gwak-Seungju
approved these changes
Sep 27, 2024
D0Dam
approved these changes
Sep 27, 2024
|
체크 리스트 확인했으면 체크해 주시면 좋을 것 같아요! 어디에 해당하는 프로젝트 이슈인지 남겨주어도 좋을 것 같아요! |
- css trasform 함수 중복 제거 - close -> open 으로 바꿔서 상태 단축
기존에는 최대한 svg 코드를 건들지 않고 수정하는 방향을 생각해서 css 파일을 수정하였습니다. 리뷰 해주신 내용을 바탕으로 생각해 봤는데, 화살표 방향의 상태를 변경하면 가독성이 좋아지고 css에서 함수도 덜 쓰기 때문에 해당 방법으로 수정하였습니다 !! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR? 🔍
Changes 📝
식단 펼치기 기능 화살표 방향 문제를 해결하였습니다.
ScreenShot 📷
Test CheckList ✅
Precaution
✔️ Please check if the PR fulfills these requirements
developbranch unconditionally?main?yarn lint