Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IA-3639: User edition: in the Org Unit Write Type tab, warn the user that a User role OUT write restriction applies if that is the case #1810

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

hakifran
Copy link
Contributor

@hakifran hakifran commented Nov 20, 2024

What problem is this PR solving? Explain here in one sentence.

  • User edition: in the Org Unit Write Type tab, warn the user that a User role OUT write restriction applies if that is the case
    Related JIRA tickets : IA-3639

Self proofreading checklist

  • Did I use eslint and black formatters
  • Is my code clear enough and well documented
  • Are my typescript files well typed
  • New translations have been added or updated if new strings have been introduced in the frontend
  • My migrations file are included
  • Are there enough tests
  • Documentation has been included (for new feature)

Doc

Tell us where the doc can be found (docs folder, wiki, in the code...).

Changes

  • Add the user_roles_editable_org_unit_type_ids to the currentUser(to be modified or created)
  • Check if the user_roles_editable_org_unit_type_ids is not empty and display the warning message

How to test

  • Create or edit a user role and add editatble OUT
  • Go in user management and create or edit a user add the user role with editable OUT
  • Go to Org Unit Write Types tab and check the warning message

Print screen / video

Notes

Things that the reviewers should know:

  • known bugs that are out of the scope of the PR
  • other trade-offs that were made
  • does the PR depends on a PR in bluesquare-components?
  • should the PR be merged into another PR?

Follow the Conventional Commits specification

The merge message of a pull request must follow the Conventional Commits specification.

This convention helps to automatically generate release notes.

Use lowercase for consistency.

Example:

fix: empty instance pop up

Refs: IA-3665

Note that the Jira reference is preceded by a line break.

Both the line break and the Jira reference are entered in the Add an optional extended description… field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant