Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Column Imprints #45

Open
wants to merge 26 commits into
base: main
Choose a base branch
from
Open

Add Column Imprints #45

wants to merge 26 commits into from

Conversation

altramarine
Copy link

This branch added column imprints into Bliss.

@altramarine
Column Imprints integration
e1d2135
@altramarine
fix gitfetch, pack column imprints
29bd6ee
@altramarine
fix git fetch url
0213125
@altramarine
fixing Cmake
4eacf30
@altramarine
remove Boost library, replaced by an type_name input in constructing …
88c5616 
…funtion
@altramarine
remove Boost library, replaced by a type_name input in construct func…
8f47eaa 
…tion
@altramarine
default arg for imprint changes
8a3cfd7
@altramarine
change tests
7585929
@altramarine
add build test for Imprints
ac02be5
@altramarine
remove 1.txt
c6503d5
@altramarine
Column Imprints integration
ad8b239
@altramarine
fix gitfetch, pack column imprints
1bb32a7
@altramarine
fix git fetch url
2186e2f
@altramarine
fixing Cmake
b2344cf
@altramarine
remove Boost library, replaced by an type_name input in constructing …
18ef4e5 
…funtion
@altramarine
remove Boost library, replaced by a type_name input in construct func…
3c524af 
…tion
@altramarine
default arg for imprint changes
3e95cec
@altramarine
change tests
63a9566
@altramarine
add build test for Imprints
5de3e3b
@altramarine
remove 1.txt
1ba6bd6
@altramarine
merge from main
878e518
@altramarine
slightly changed include
5cebac2
@ramananeesh ramananeesh requested a review from ephoris January 21, 2025 19:37
ramananeesh
ramananeesh requested changes Jan 21, 2025
View reviewed changes
Copy link
Collaborator

@ramananeesh ramananeesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@altramarine please review the comments and make necessary changes.

src/bliss/bench_imprints.h Outdated Show resolved Hide resolved
src/bliss/bench_imprints.h Outdated Show resolved Hide resolved
src/bliss/util/execute.h Outdated Show resolved Hide resolved
src/bliss_bench.cpp Outdated Show resolved Hide resolved
tests/test_imprints/imprint_tests.cpp Outdated Show resolved Hide resolved
tests/test_imprints/imprint_tests.cpp Outdated Show resolved Hide resolved
tests/test_imprints/imprint_tests.cpp Outdated Show resolved Hide resolved
ramananeesh
ramananeesh approved these changes Feb 6, 2025
View reviewed changes
Copy link
Collaborator

@ramananeesh ramananeesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

ephoris
ephoris approved these changes Feb 6, 2025
View reviewed changes
Copy link
Collaborator

@ephoris ephoris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ephoris ephoris ephoris approved these changes

@ramananeesh ramananeesh ramananeesh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@altramarine @ephoris @ramananeesh