Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate ByteSlice into bliss #48

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

altramarine
Copy link

No description provided.

Copy link
Collaborator

@ramananeesh ramananeesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@altramarine please address the comments and re-request the review once ready.

src/bliss/bench_byteslice.h Outdated Show resolved Hide resolved
src/bliss/bench_byteslice.h Outdated Show resolved Hide resolved
src/bliss/bench_byteslice.h Outdated Show resolved Hide resolved
@altramarine
Copy link
Author

The get(start, end) function is not correct in main repo, the return should be a newly created bitmap indicating which row is selected in range scan not a bool. I think we canfirst squash and merge this before merging other scan accelorators.

@ramananeesh
Copy link
Collaborator

The get(start, end) function is not correct in main repo, the return should be a newly created bitmap indicating which row is selected in range scan not a bool. I think we canfirst squash and merge this before merging other scan accelorators.

So there are two ways to approach range query functions - one is to return the bool indicating that we did find some results, and the other is the returned entries themselves in a map/array.

Since this is a benchmarking tool, we "assume" correctness of the code we are integrating. Hence, we do not need to return the bitmap of the results, a bool will suffice.

@altramarine
Copy link
Author

I think I have resolved everything and it is ready to merge with main

Copy link
Collaborator

@ephoris ephoris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@ramananeesh ramananeesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrating ByteSlice to the benchmark
3 participants