-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate ByteSlice into bliss #48
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@altramarine please address the comments and re-request the review once ready.
The get(start, end) function is not correct in main repo, the return should be a newly created bitmap indicating which row is selected in range scan not a bool. I think we canfirst squash and merge this before merging other scan accelorators. |
So there are two ways to approach range query functions - one is to return the bool indicating that we did find some results, and the other is the returned entries themselves in a map/array. Since this is a benchmarking tool, we "assume" correctness of the code we are integrating. Hence, we do not need to return the bitmap of the results, a bool will suffice. |
I think I have resolved everything and it is ready to merge with main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
No description provided.