fixed name overflow on sprites #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BXC-94 Delete sprite
Button on active sprite button that allows the user to delete a sprite from their project |
ElliotRoe
requested changes
Sep 27, 2023
Comment on lines
16
to
28
| let inputName = '' | ||
|
|
||
| // Upon a name change, re-render the sprite's card in a local variable. | ||
| // useEffect(() => { | ||
| // if ((target?.sprite?.name).length > 16) { | ||
| // inputName = (target?.sprite?.name).substring(0, 13) + '...' | ||
| // } | ||
| // else { | ||
| // inputName = target?.sprite?.name | ||
| // } | ||
|
|
||
| // }, [target?.sprite?.name]) | ||
|
|
| </ItemCard> | ||
| return ( | ||
| <> | ||
| {target?.sprite?.name.length > 13 ? |
There was a problem hiding this comment.
Would probably refactor this ternary into an if statement in the body of the component's function. Just so we don't have to repeat a bunch of JSX
Comment on lines
40
to
42
| useEffect(() => { | ||
| console.log("user is typing") | ||
| }, [name]) |
There was a problem hiding this comment.
Remove debug statements
|
I refactored the ternary operator and also removed the debug statement in spriteName.tsx. |
ElliotRoe
approved these changes
Feb 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added name overflow on long sprite names (#94 )