Skip to content

Commit

Permalink
revert: update (upload,download)-artifact to v4
Browse files Browse the repository at this point in the history
~reverts commit 399b8d3. (the action was moved later).
This downgrades the action again to v3.
The download action seems to run into a timeout sometimes.
This was better with v4.
  • Loading branch information
BacLuc committed Dec 22, 2023
1 parent f6a4db4 commit 96a3899
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/reusable-e2e-tests-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ jobs:
cache-to: type=gha,scope=caddy,mode=max
outputs: type=docker,dest=/tmp/ecamp3-dev-api-caddy.tar

- uses: actions/upload-artifact@v4
- uses: actions/upload-artifact@v3
with:
name: e2e-tests-images
path: /tmp/ecamp3-dev-*.tar
4 changes: 2 additions & 2 deletions .github/workflows/reusable-e2e-tests-run.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
uses: docker/setup-buildx-action@v3

- name: Restore tmp folder
uses: actions/download-artifact@v4
uses: actions/download-artifact@v3
with:
name: e2e-tests-images
path: /tmp
Expand Down Expand Up @@ -59,7 +59,7 @@ jobs:
wait-on-timeout: 300

# store screenshots and videos on GitHub as artifacts, for downloading and debugging in case of problems
- uses: actions/upload-artifact@v4
- uses: actions/upload-artifact@v3
if: always()
with:
name: cypress-output-${{ matrix.browser }}${{ inputs.run-identifier != null && format('-{0}', inputs.run-identifier) }}
Expand Down

0 comments on commit 96a3899

Please sign in to comment.